summaryrefslogtreecommitdiff
path: root/sound/ac97
diff options
context:
space:
mode:
authorYufen Yu <yuyufen@huawei.com>2021-05-24 05:38:11 -0400
committerTakashi Iwai <tiwai@suse.de>2021-05-25 08:59:08 +0200
commita38e93302ee25b2ca6f4ee76c6c974cf3637985e (patch)
tree682d6ffbdebdc1fd6e3c28cc7f060742ac19a7ad /sound/ac97
parent877013bc9cbdd37dfc12d87feca4e368d38ebc6f (diff)
downloadlinux-a38e93302ee25b2ca6f4ee76c6c974cf3637985e.tar.gz
ALSA: ac97: fix PM reference leak in ac97_bus_remove()
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yufen Yu <yuyufen@huawei.com> Link: https://lore.kernel.org/r/20210524093811.612302-1-yuyufen@huawei.com Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/ac97')
-rw-r--r--sound/ac97/bus.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/ac97/bus.c b/sound/ac97/bus.c
index d9077e91382b..6ddf646cda65 100644
--- a/sound/ac97/bus.c
+++ b/sound/ac97/bus.c
@@ -520,7 +520,7 @@ static int ac97_bus_remove(struct device *dev)
struct ac97_codec_driver *adrv = to_ac97_driver(dev->driver);
int ret;
- ret = pm_runtime_get_sync(dev);
+ ret = pm_runtime_resume_and_get(dev);
if (ret < 0)
return ret;