diff options
| author | Petr Pisar <ppisar@redhat.com> | 2011-05-12 13:13:56 +0200 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2011-05-16 17:39:33 +0200 |
| commit | 3ad0b3622cf92989584097787323f00bc7a36c48 (patch) | |
| tree | 60f203a986e4f36d5ae7723258cec91ab277ad0c /convertquota.c | |
| parent | c3a392437a2ec4793f2b1112058de0c3b459b6fe (diff) | |
| download | linuxquota-3ad0b3622cf92989584097787323f00bc7a36c48.tar.gz | |
Make global symbols static as possible
There are some calls (e.g. getpwnam(3)) that can lead to dlopening
other libraries that could jump to symbol with name clashing to one of
global quota symbols. (e.g. Name server switch plug-in nss_db calls
dirname(3) that's already defined in edquota.c and tht can cause
segmentation fault.)
Although it's not possible to solve all these problems, making as much
as possible global objects and functions static is the best thing we
can do to avoid name space polution.
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'convertquota.c')
| -rw-r--r-- | convertquota.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/convertquota.c b/convertquota.c index 1e40804..483abf1 100644 --- a/convertquota.c +++ b/convertquota.c @@ -29,12 +29,12 @@ #define ACT_FORMAT 1 /* Convert format from old to new */ #define ACT_ENDIAN 2 /* Convert endianity */ -char *mntpoint; +static char *mntpoint; char *progname; -int ucv, gcv; -struct quota_handle *qn; /* Handle of new file */ -int action; /* Action to be performed */ -int infmt, outfmt; +static int ucv, gcv; +static struct quota_handle *qn; /* Handle of new file */ +static int action; /* Action to be performed */ +static int infmt, outfmt; static void usage(void) { |