diff options
| author | Siddhartha Bagaria <sbagaria@grailbio.com> | 2020-03-30 14:20:58 -0400 |
|---|---|---|
| committer | Scott Linder <Scott.Linder@amd.com> | 2020-03-30 15:02:33 -0400 |
| commit | 3c371491a2d5023060391ff54b924bf1c7a0c41f (patch) | |
| tree | e7eb6c4ee879ff220e2a413dbcf3cb621ac79116 /.arclint | |
| parent | 0af6d27e2ee2aa7365449e0f3c0f4727357a9584 (diff) | |
| download | llvm-3c371491a2d5023060391ff54b924bf1c7a0c41f.tar.gz | |
Setup clang-format as an Arcanist linter
Summary:
This uses clang-format-diff as a linter for Arcanist.
`arc lint` flow, also run as part of `arc diff` unless skipped with
`--nolint`, will now run the linter shell script on the changed files,
and prompt the user to accept the suggested changes.
Message when clang-format-diff is not installed:
{F6654094}
Example of the noise during code review when clang-format-diff is not installed:
https://reviews.llvm.org/differential/changeset/?ref=1115809
Prompt when clang-format-diff is installed and suggests edits:
{F6650223}
Reviewers: probinson, scott.linder
Reviewed By: scott.linder
Subscribers: scott.linder, MyDeveloperDay, JonasToth, danilaml, JDevlieghere, dberris, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D49116
Diffstat (limited to '.arclint')
| -rw-r--r-- | .arclint | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/.arclint b/.arclint new file mode 100644 index 000000000000..01de1ee897ad --- /dev/null +++ b/.arclint @@ -0,0 +1,12 @@ +{ + "linters": { + "clang-format": { + "type": "script-and-regex", + "script-and-regex.script": "utils/arcanist/clang-format.sh", + "script-and-regex.regex": "/^(?P<severity>[[:alpha:]]+)\n(?P<message>[^\n]+)\n(====|(?P<line>\\d),(?P<char>\\d)\n(?P<original>.*)>>>>\n(?P<replacement>.*)<<<<\n)$/s", + "include": [ + "(\\.(cc|cpp|h)$)" + ] + } + } +} |