diff options
author | Alex Lorenz <arphaman@gmail.com> | 2015-08-13 20:55:01 +0000 |
---|---|---|
committer | Alex Lorenz <arphaman@gmail.com> | 2015-08-13 20:55:01 +0000 |
commit | 6866104073e365ef1d3b583e2fa8c7ceaf2cac8e (patch) | |
tree | 48dae234e270edc1f02430ea9a1afa8749f3d153 | |
parent | 0e7ac9ab2b2646929534ac0c8ddc4a5bac68980d (diff) | |
download | llvm-studio-1.4.tar.gz |
MIR Parser: Don't allow negative alignments for memory operands.studio-1.4
llvm-svn: 244953
-rw-r--r-- | llvm/lib/CodeGen/MIRParser/MIParser.cpp | 2 | ||||
-rw-r--r-- | llvm/test/CodeGen/MIR/X86/expected-positive-alignment-after-align.mir | 32 |
2 files changed, 33 insertions, 1 deletions
diff --git a/llvm/lib/CodeGen/MIRParser/MIParser.cpp b/llvm/lib/CodeGen/MIRParser/MIParser.cpp index 389c5aaec8c7..46ad8769fd39 100644 --- a/llvm/lib/CodeGen/MIRParser/MIParser.cpp +++ b/llvm/lib/CodeGen/MIRParser/MIParser.cpp @@ -1077,7 +1077,7 @@ bool MIParser::parseOffset(int64_t &Offset) { bool MIParser::parseAlignment(unsigned &Alignment) { assert(Token.is(MIToken::kw_align)); lex(); - if (Token.isNot(MIToken::IntegerLiteral)) + if (Token.isNot(MIToken::IntegerLiteral) || Token.integerValue().isSigned()) return error("expected an integer literal after 'align'"); if (getUnsigned(Alignment)) return true; diff --git a/llvm/test/CodeGen/MIR/X86/expected-positive-alignment-after-align.mir b/llvm/test/CodeGen/MIR/X86/expected-positive-alignment-after-align.mir new file mode 100644 index 000000000000..442d2fa75389 --- /dev/null +++ b/llvm/test/CodeGen/MIR/X86/expected-positive-alignment-after-align.mir @@ -0,0 +1,32 @@ +# RUN: not llc -march=x86-64 -start-after branch-folder -stop-after branch-folder -o /dev/null %s 2>&1 | FileCheck %s + +--- | + + define void @memory_alignment(<8 x float>* %vec) { + entry: + %v = load <8 x float>, <8 x float>* %vec + %v2 = insertelement <8 x float> %v, float 0.0, i32 4 + store <8 x float> %v2, <8 x float>* %vec + ret void + } + +... +--- +name: memory_alignment +tracksRegLiveness: true +liveins: + - { reg: '%rdi' } +body: + - id: 0 + name: entry + liveins: [ '%rdi' ] + instructions: +# CHECK: [[@LINE+1]]:76: expected an integer literal after 'align' + - '%xmm0 = MOVAPSrm %rdi, 1, _, 0, _ :: (load 16 from %ir.vec, align -32)' + - '%xmm1 = MOVAPSrm %rdi, 1, _, 16, _ :: (load 16 from %ir.vec + 16, align 32)' + - '%xmm2 = FsFLD0SS' + - '%xmm1 = MOVSSrr killed %xmm1, killed %xmm2' + - 'MOVAPSmr %rdi, 1, _, 0, _, killed %xmm0 :: (store 16 into %ir.vec, align 32)' + - 'MOVAPSmr killed %rdi, 1, _, 16, _, killed %xmm1 :: (store 16 into %ir.vec + 16, align 32)' + - RETQ +... |