diff options
author | Jennifer Yu <jennifer.yu@intel.com> | 2023-05-10 15:01:52 -0700 |
---|---|---|
committer | Jennifer Yu <jennifer.yu@intel.com> | 2023-05-17 14:42:39 -0700 |
commit | 691927c904ede183461610387402f5c19dbb3de0 (patch) | |
tree | cfbf912f081baf83d0507d98767aa2cb3ce8370f | |
parent | fcf0a7bfd1c030ff45866f54415179d3ca5cbfc5 (diff) | |
download | llvm-691927c904ede183461610387402f5c19dbb3de0.tar.gz |
Fix assertion when try is used inside catch(...) block
Current assert wiht /EHa:
A single unwind edge may only enter one EH pad
invoke void @llvm.seh.try.begin()
to label %invoke.cont1 unwind label %catch.dispatch2
Current IR:
%1 = catchpad within %0 [ptr null, i32 0, ptr null]
invoke void @llvm.seh.try.begin()
to label %invoke.cont5 unwind label %catch.dispatch2
The problem is the invoke to llvm.seh.try.begin() missing "funclet"
Accodring: https://llvm.org/docs/LangRef.html#ob-funclet
If any "funclet" EH pads have been entered but not exited (per the
description in the EH doc), it is undefined behavior to execute a
call or invoke.
To fix the problem, when emit seh_try_begin, call EmitSehTryScopeBegin,
instead of calling EmitRuntimeCallOrInvoke for proper "funclet"
gerenration.
Differential Revision: https://reviews.llvm.org/D150340
-rw-r--r-- | clang/lib/CodeGen/CGException.cpp | 2 | ||||
-rw-r--r-- | clang/test/CodeGen/windows-seh-EHa-CppCatchDotDotDot.cpp | 27 |
2 files changed, 28 insertions, 1 deletions
diff --git a/clang/lib/CodeGen/CGException.cpp b/clang/lib/CodeGen/CGException.cpp index 3707c8792491..8b0776b9a52b 100644 --- a/clang/lib/CodeGen/CGException.cpp +++ b/clang/lib/CodeGen/CGException.cpp @@ -646,7 +646,7 @@ void CodeGenFunction::EnterCXXTryStmt(const CXXTryStmt &S, bool IsFnTryBlock) { // Under async exceptions, catch(...) need to catch HW exception too // Mark scope with SehTryBegin as a SEH __try scope if (getLangOpts().EHAsynch) - EmitRuntimeCallOrInvoke(getSehTryBeginFn(CGM)); + EmitSehTryScopeBegin(); } } } diff --git a/clang/test/CodeGen/windows-seh-EHa-CppCatchDotDotDot.cpp b/clang/test/CodeGen/windows-seh-EHa-CppCatchDotDotDot.cpp index 047894c395bb..c9e6c9925edd 100644 --- a/clang/test/CodeGen/windows-seh-EHa-CppCatchDotDotDot.cpp +++ b/clang/test/CodeGen/windows-seh-EHa-CppCatchDotDotDot.cpp @@ -9,11 +9,21 @@ // CHECK: %[[dst1:[0-9-]+]] = catchpad within %[[dst]] [ptr null, i32 0, ptr null] // CHECK: "funclet"(token %[[dst1]]) +// CHECK: define dso_local void @"?bar@@YAXXZ +// CHECK: invoke void @llvm.seh.try.begin() +// CHECK: invoke void @_CxxThrowException +// CHECK: %[[dst:[0-9-]+]] = catchpad within %0 [ptr null, i32 0, ptr null] +// CHECK: invoke void @llvm.seh.try.begin() [ "funclet"(token %[[dst]]) ] + // CHECK: invoke void @llvm.seh.try.begin() // CHECK: %[[src:[0-9-]+]] = load volatile i32, ptr %i // CHECK-NEXT: invoke void @"?crash@@YAXH@Z"(i32 noundef %[[src]]) // CHECK: invoke void @llvm.seh.try.end() +// CHECK: invoke void @llvm.seh.try.begin() +// CHECK: invoke void @"?bar@@YAXXZ"() +// CHECK: invoke void @llvm.seh.try.end() + // ***************************************************************************** // Abstract: Test CPP catch(...) under SEH -EHa option @@ -46,6 +56,18 @@ void crash(int i) { } } +void bar() { + try { + throw 1; + } catch(...) { + try { + *NullPtr = 0; + } catch (...) { + throw 1; + } + } +} + int main() { for (int i = 0; i < 2; i++) { __try { @@ -54,5 +76,10 @@ int main() { printf(" Test CPP unwind: in except handler i = %d \n", i); } } + __try { + bar(); + } __except (1) { + printf("Test CPP unwind: in except handler \n"); + } return 0; } |