diff options
author | Haojian Wu <hokein.wu@gmail.com> | 2023-03-06 11:45:44 +0100 |
---|---|---|
committer | Haojian Wu <hokein.wu@gmail.com> | 2023-03-06 13:18:43 +0100 |
commit | b2897ad70301ae669328795eebc894d383d787c1 (patch) | |
tree | e20b3eb564e6081b1cbb715c86b99e2c1541fd39 /clang-tools-extra/include-cleaner | |
parent | aff18638591b40dbba51e9e9f75973a242bcb276 (diff) | |
download | llvm-b2897ad70301ae669328795eebc894d383d787c1.tar.gz |
[include-cleaner] Fix a crash on non-identifier-name symbols.
Differential Revision: https://reviews.llvm.org/D145364
Diffstat (limited to 'clang-tools-extra/include-cleaner')
-rw-r--r-- | clang-tools-extra/include-cleaner/lib/FindHeaders.cpp | 2 | ||||
-rw-r--r-- | clang-tools-extra/include-cleaner/test/nocrash.cpp | 8 |
2 files changed, 9 insertions, 1 deletions
diff --git a/clang-tools-extra/include-cleaner/lib/FindHeaders.cpp b/clang-tools-extra/include-cleaner/lib/FindHeaders.cpp index ae2a3a858a38..e273d429cd8c 100644 --- a/clang-tools-extra/include-cleaner/lib/FindHeaders.cpp +++ b/clang-tools-extra/include-cleaner/lib/FindHeaders.cpp @@ -118,7 +118,7 @@ headersForSpecialSymbol(const Symbol &S, const SourceManager &SM, if (!FD) return {}; - llvm::StringRef FName = FD->getName(); + llvm::StringRef FName = symbolName(S); llvm::SmallVector<tooling::stdlib::Header> Headers; if (FName == "move") { if (FD->getNumParams() == 1) diff --git a/clang-tools-extra/include-cleaner/test/nocrash.cpp b/clang-tools-extra/include-cleaner/test/nocrash.cpp new file mode 100644 index 000000000000..60e0f098867c --- /dev/null +++ b/clang-tools-extra/include-cleaner/test/nocrash.cpp @@ -0,0 +1,8 @@ +// RUN: clang-include-cleaner %s -- + +namespace std { +class Foo {}; +bool operator==(Foo, int) { return false; } +} +// no crash on a reference to a non-identifier symbol (operator ==). +bool s = std::operator==(std::Foo(), 1); |