diff options
| author | Shivam Gupta <Shivam.Gupta2@amd.com> | 2023-04-15 23:53:56 +0530 |
|---|---|---|
| committer | Shivam Gupta <Shivam.Gupta2@amd.com> | 2023-04-17 10:23:53 +0530 |
| commit | 726199146a0bb53315ade042e759c65e6d96d556 (patch) | |
| tree | b376657f42e487057ef2a77449e3084fd6c26740 /clang/tools | |
| parent | 9fdf82dc32dc38e0b92dab3215a83d8f3c2f9bbf (diff) | |
| download | llvm-726199146a0bb53315ade042e759c65e6d96d556.tar.gz | |
[clang-rename] Exit gracefully when no input provided
clang-rename on a non existing file segfaults
Command to run -
$ clang-rename -offset=0 -new-name=plop asdasd
Error while processing llvm-project/asdasd.
clang-rename: llvm-project/llvm/include/llvm/Support/ErrorOr.h:237:
llvm::ErrorOr<T>::storage_type* llvm::ErrorOr<T>::getStorage()
[with T = const clang::FileEntry*; llvm::ErrorOr<T>::storage_type = const clang::FileEntry*]:
Assertion `!HasError && "Cannot get value when an error exists!"' failed.
[1] 827497 IOT instruction clang-rename -offset=0 -new-name=plop asdasd
Differential Revision: https://reviews.llvm.org/D148439
Diffstat (limited to 'clang/tools')
| -rw-r--r-- | clang/tools/clang-rename/ClangRename.cpp | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/clang/tools/clang-rename/ClangRename.cpp b/clang/tools/clang-rename/ClangRename.cpp index e7ceac7dbf30..7ba1978f0774 100644 --- a/clang/tools/clang-rename/ClangRename.cpp +++ b/clang/tools/clang-rename/ClangRename.cpp @@ -126,6 +126,9 @@ int main(int argc, const char **argv) { SymbolOffsets.push_back(Info.Offset); NewNames.push_back(Info.NewName); } + } else { + errs() << "clang-rename: input must be provided.\n"; + return 1; } // Check the arguments for correctness. |