diff options
author | Alvin Wong <alvin@alvinhc.com> | 2023-05-11 17:26:03 +0800 |
---|---|---|
committer | Alvin Wong <alvin@alvinhc.com> | 2023-05-16 19:53:12 +0800 |
commit | 3237f568403b80a6df47dd88dcfb03cb3a99b633 (patch) | |
tree | 4952ddf9e9c77d584488cb6045d5f330a1127f4d /compiler-rt | |
parent | fe5786d41644ec6c739b6ace49d654a21a07cca0 (diff) | |
download | llvm-3237f568403b80a6df47dd88dcfb03cb3a99b633.tar.gz |
[asan][win][test] Disable interception_failure_test.cpp for static asan
This test checks that asan does not intercept user-provided libc
functions, but on Windows the static asan runtime does intercept static
copies of libc functions, so this test is invalid for said environment.
It used to fail from a different linker error, but this no longer
happens with newer WinSDK. Refer to comments on
https://reviews.llvm.org/D149549.
Differential Revision: https://reviews.llvm.org/D150349
Diffstat (limited to 'compiler-rt')
-rw-r--r-- | compiler-rt/test/asan/TestCases/interception_failure_test.cpp | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/compiler-rt/test/asan/TestCases/interception_failure_test.cpp b/compiler-rt/test/asan/TestCases/interception_failure_test.cpp index 7e2413ec2a23..918fa8e82bf7 100644 --- a/compiler-rt/test/asan/TestCases/interception_failure_test.cpp +++ b/compiler-rt/test/asan/TestCases/interception_failure_test.cpp @@ -7,9 +7,12 @@ // RUN: %clangxx_asan -O3 %s -o %t && %run %t 2>&1 | FileCheck %s // XFAIL: target={{.*freebsd.*}} -// On Windows, defining strtoll in a static build results in linker errors, but -// it works with the dynamic runtime. -// XFAIL: win32-static-asan +// On Windows, the static runtime build _will_ intercept static copies of libc +// functions, making this test invalid. +// In addition, defining strtol in a static build used to result in linker +// errors with libucrt.lib, but this stopped happening somewhere between WinSDK +// 10.0.19041.0 and 10.0.22621.0 due to some changes in its implementation. +// UNSUPPORTED: win32-static-asan // On NetBSD, defining strtol in a static build results in linker errors, but // it works with the dynamic runtime. |