diff options
| author | Philip Reames <preames@rivosinc.com> | 2022-06-08 07:11:12 -0700 |
|---|---|---|
| committer | Philip Reames <listmail@philipreames.com> | 2022-06-08 07:32:37 -0700 |
| commit | f0d2a55d3aa68827ad708a16650bb0b341ca65bb (patch) | |
| tree | a2f34f823d8acd2563e80eba06f76ca870e5c447 /cross-project-tests | |
| parent | 33ead6e444ceb11c6785827fc9c1ed6deebc9209 (diff) | |
| download | llvm-f0d2a55d3aa68827ad708a16650bb0b341ca65bb.tar.gz | |
Restore isa<Ty>(X) asserts inside cast<Ty>(X)
PLEASE DO NOT REVERT without careful consideration, and preferably prior
discussion.
cast<Ty>(X) is a "checked cast". Its entire purpose is explicitly documented
(https://llvm.org/docs/ProgrammersManual.html#the-isa-cast-and-dyn-cast
templates) as catching bad casts by asserting that the cast is valid.
Unfortunately, in a recent rewrite of our casting infrastructure about three
months back, these asserts got dropped.
This is discussed in more detail on discourse in https://discourse.llvm.org/t/cast-x-is-broken-implications-and-proposal-to-address/63033.
Differential Revision: https://reviews.llvm.org/D127231
Diffstat (limited to 'cross-project-tests')
0 files changed, 0 insertions, 0 deletions