diff options
| author | Petr Hosek <phosek@chromium.org> | 2019-01-28 04:12:54 +0000 |
|---|---|---|
| committer | Petr Hosek <phosek@chromium.org> | 2019-01-28 04:12:54 +0000 |
| commit | b667153cf65e66dd5e14e6a715fb33e6200e91de (patch) | |
| tree | cebdd739193eb68d301c7bfeb2dfc26e9926b882 /libcxxabi/cmake | |
| parent | fd31bf95c1479e26d77c9000c238ffa36929747f (diff) | |
| download | llvm-b667153cf65e66dd5e14e6a715fb33e6200e91de.tar.gz | |
[CMake] Use __libc_start_main rather than fopen when checking for C library
The check_library_exists CMake uses a custom symbol definition. This
is a problem when checking for C library symbols because Clang
recognizes many of them as builtins, and returns the
-Wbuiltin-requires-header (or -Wincompatible-library-redeclaration)
error. When building with -Werror which is the default, this causes
the check_library_exists check fail making the build think that C
library isn't available.
To avoid this issue, we should use a symbol that isn't recognized by
Clang and wouldn't cause the same issue. __libc_start_main seems like
reasonable choice that fits the bill.
Differential Revision: https://reviews.llvm.org/D57142
llvm-svn: 352341
Diffstat (limited to 'libcxxabi/cmake')
| -rw-r--r-- | libcxxabi/cmake/config-ix.cmake | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libcxxabi/cmake/config-ix.cmake b/libcxxabi/cmake/config-ix.cmake index 379b55477497..4be7adc81dd4 100644 --- a/libcxxabi/cmake/config-ix.cmake +++ b/libcxxabi/cmake/config-ix.cmake @@ -2,7 +2,7 @@ include(CheckLibraryExists) include(CheckCCompilerFlag) include(CheckCXXCompilerFlag) -check_library_exists(c fopen "" LIBCXXABI_HAS_C_LIB) +check_library_exists(c __libc_start_main "" LIBCXXABI_HAS_C_LIB) if (NOT LIBCXXABI_USE_COMPILER_RT) check_library_exists(gcc_s __gcc_personality_v0 "" LIBCXXABI_HAS_GCC_S_LIB) endif () |