diff options
| author | Teresa Johnson <tejohnson@google.com> | 2023-04-19 14:51:10 -0700 |
|---|---|---|
| committer | Teresa Johnson <tejohnson@google.com> | 2023-04-20 11:45:15 -0700 |
| commit | 3adc6e03080c6d38a51f5c5b6744b7c0d9c7541b (patch) | |
| tree | e95855cb0ec33430203bd1d118fa48d6990f2af0 /lld | |
| parent | 3ba4d082da3dd6856887774fab694f81adc15a64 (diff) | |
| download | llvm-3adc6e03080c6d38a51f5c5b6744b7c0d9c7541b.tar.gz | |
[ThinLTO] Remove BlockCount for non partial sample profile builds
As pointed out in
https://discourse.llvm.org/t/undeterministic-thin-index-file/69985, the
block count added to distributed ThinLTO index files breaks incremental
builds on ThinLTO - if any linked file has a different number of BBs,
then the accumulated sum placed in the index files will change, causing
all ThinLTO backend compiles to be redone.
The block count is only used for scaling of partial sample profiles, and
was added in D80403 for D79831.
This patch simply removes this field from the index files of non partial
sample profile compiles, which is NFC on the output of the compiler.
We subsequently need to see if this can be removed for partial sample
profiles without signficant performance loss, or redesigned in a way
that does not destroy caching.
Differential Revision: https://reviews.llvm.org/D148746
Diffstat (limited to 'lld')
| -rw-r--r-- | lld/test/COFF/thinlto-index-only.ll | 1 | ||||
| -rw-r--r-- | lld/test/ELF/lto/thinlto-emit-index.ll | 1 | ||||
| -rw-r--r-- | lld/test/ELF/lto/thinlto-index-only.ll | 1 | ||||
| -rw-r--r-- | lld/test/MachO/thinlto-emit-index.ll | 1 | ||||
| -rw-r--r-- | lld/test/MachO/thinlto-index-only.ll | 1 |
5 files changed, 0 insertions, 5 deletions
diff --git a/lld/test/COFF/thinlto-index-only.ll b/lld/test/COFF/thinlto-index-only.ll index 8abc7b5213c9..996c888cbe22 100644 --- a/lld/test/COFF/thinlto-index-only.ll +++ b/lld/test/COFF/thinlto-index-only.ll @@ -39,7 +39,6 @@ ; BACKEND2-NEXT: <FLAGS ; BACKEND2-NEXT: <VALUE_GUID op0=1 op1=-5300342847281564238 ; BACKEND2-NEXT: <COMBINED -; BACKEND2-NEXT: <BLOCK_COUNT op0=2/> ; BACKEND2-NEXT: </GLOBALVAL_SUMMARY_BLOCK ; Thin archive tests. Check that the module paths point to the original files. diff --git a/lld/test/ELF/lto/thinlto-emit-index.ll b/lld/test/ELF/lto/thinlto-emit-index.ll index 643ecb9b2879..ae8b4ddeb1bf 100644 --- a/lld/test/ELF/lto/thinlto-emit-index.ll +++ b/lld/test/ELF/lto/thinlto-emit-index.ll @@ -92,7 +92,6 @@ ; BACKEND2-NEXT: <FLAGS ; BACKEND2-NEXT: <VALUE_GUID op0=1 op1=-5300342847281564238 ; BACKEND2-NEXT: <COMBINED -; BACKEND2-NEXT: <BLOCK_COUNT op0=2/> ; BACKEND2-NEXT: </GLOBALVAL_SUMMARY_BLOCK target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" diff --git a/lld/test/ELF/lto/thinlto-index-only.ll b/lld/test/ELF/lto/thinlto-index-only.ll index dc84df9b870c..0b64958007b2 100644 --- a/lld/test/ELF/lto/thinlto-index-only.ll +++ b/lld/test/ELF/lto/thinlto-index-only.ll @@ -90,7 +90,6 @@ ; BACKEND2-NEXT: <FLAGS ; BACKEND2-NEXT: <VALUE_GUID op0=1 op1=-5300342847281564238 ; BACKEND2-NEXT: <COMBINED -; BACKEND2-NEXT: <BLOCK_COUNT op0=2/> ; BACKEND2-NEXT: </GLOBALVAL_SUMMARY_BLOCK target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" diff --git a/lld/test/MachO/thinlto-emit-index.ll b/lld/test/MachO/thinlto-emit-index.ll index fdc1f4850902..6f8d552f1435 100644 --- a/lld/test/MachO/thinlto-emit-index.ll +++ b/lld/test/MachO/thinlto-emit-index.ll @@ -92,7 +92,6 @@ ; BACKEND2-NEXT: <FLAGS ; BACKEND2-NEXT: <VALUE_GUID op0=1 op1=-5300342847281564238 ; BACKEND2-NEXT: <COMBINED -; BACKEND2-NEXT: <BLOCK_COUNT op0=2/> ; BACKEND2-NEXT: </GLOBALVAL_SUMMARY_BLOCK diff --git a/lld/test/MachO/thinlto-index-only.ll b/lld/test/MachO/thinlto-index-only.ll index 54819a2d397b..a97cd126ad5b 100644 --- a/lld/test/MachO/thinlto-index-only.ll +++ b/lld/test/MachO/thinlto-index-only.ll @@ -91,7 +91,6 @@ ; BACKEND2-NEXT: <FLAGS ; BACKEND2-NEXT: <VALUE_GUID op0=1 op1=-5300342847281564238 ; BACKEND2-NEXT: <COMBINED -; BACKEND2-NEXT: <BLOCK_COUNT op0=2/> ; BACKEND2-NEXT: </GLOBALVAL_SUMMARY_BLOCK ;--- f.ll |