diff options
| author | Jonas Devlieghere <jonas@devlieghere.com> | 2018-12-20 20:44:23 +0000 |
|---|---|---|
| committer | Jonas Devlieghere <jonas@devlieghere.com> | 2018-12-20 20:44:23 +0000 |
| commit | dcc8fc9e985f16a6df878ec0ff7212e0a2da0c8f (patch) | |
| tree | e66790e7035a5a7dbdd67ebfe3655cb80926a003 /lldb/third_party | |
| parent | 3b7e8b2dbb1213d35917556f3e917d7add583506 (diff) | |
| download | llvm-dcc8fc9e985f16a6df878ec0ff7212e0a2da0c8f.tar.gz | |
[dotest] Consider unexpected passes as failures.
Unexpected successes should be considered failures because they can hide
regressions when not addressed. When a test is fixed and not re-enabled,
it can easily regress without us noticing.
I couldn't find a good way to make this change other than changing it in
the unittest2 framework. I know this is less than optimal but since we
have the dependency checked in and the change is pretty fundamental to
the framework I think it's not unreasonable.
Differential revision: https://reviews.llvm.org/D55835
llvm-svn: 349818
Diffstat (limited to 'lldb/third_party')
| -rw-r--r-- | lldb/third_party/Python/module/unittest2/unittest2/result.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lldb/third_party/Python/module/unittest2/unittest2/result.py b/lldb/third_party/Python/module/unittest2/unittest2/result.py index 9d76429fb4ad..8f89816b772f 100644 --- a/lldb/third_party/Python/module/unittest2/unittest2/result.py +++ b/lldb/third_party/Python/module/unittest2/unittest2/result.py @@ -148,7 +148,9 @@ class TestResult(unittest.TestResult): def wasSuccessful(self): "Tells whether or not this result was a success" - return (len(self.failures) + len(self.errors) == 0) + return (len(self.failures) + + len(self.errors) + + len(self.unexpectedSuccesses) == 0) def stop(self): "Indicates that the tests should be aborted" |