summaryrefslogtreecommitdiff
path: root/mlir/docs
diff options
context:
space:
mode:
authorQuentin Colombet <quentin.colombet@gmail.com>2023-01-24 13:05:47 +0000
committerQuentin Colombet <quentin.colombet@gmail.com>2023-01-27 09:10:10 +0000
commitcb4ccd38fa0407928feed7e39d197169eabc95b2 (patch)
tree14d3a9ec627e8500de0937d1ae4a43fad8a50e9a /mlir/docs
parent88a3dc0ee88009a145e8daa875235650f07554c9 (diff)
downloadllvm-cb4ccd38fa0407928feed7e39d197169eabc95b2.tar.gz
[mlir][Conversion] Rename the MemRefToLLVM pass
Since the recent MemRef refactoring that centralizes the lowering of complex MemRef operations outside of the conversion framework, the MemRefToLLVM pass doesn't directly convert these complex operations. Instead, to fully convert the whole MemRef dialect space, MemRefToLLVM needs to run after `expand-strided-metadata`. Make this more obvious by changing the name of the pass and the option associated with it from `convert-memref-to-llvm` to `finalize-memref-to-llvm`. The word "finalize" conveys that this pass needs to run after something else and that something else is documented in its tablegen description. This is a follow-up patch related to the conversation at: https://discourse.llvm.org/t/psa-you-need-to-run-expand-strided-metadata-before-memref-to-llvm-now/66956/14 Differential Revision: https://reviews.llvm.org/D142463
Diffstat (limited to 'mlir/docs')
-rw-r--r--mlir/docs/TargetLLVMIR.md2
1 files changed, 1 insertions, 1 deletions
diff --git a/mlir/docs/TargetLLVMIR.md b/mlir/docs/TargetLLVMIR.md
index 5ba7adc2463a..03bf920a04a0 100644
--- a/mlir/docs/TargetLLVMIR.md
+++ b/mlir/docs/TargetLLVMIR.md
@@ -35,7 +35,7 @@ Conversion to the LLVM dialect from other dialects is the first step to produce
LLVM IR. All non-trivial IR modifications are expected to happen at this stage
or before. The conversion is *progressive*: most passes convert one dialect to
the LLVM dialect and keep operations from other dialects intact. For example,
-the `-convert-memref-to-llvm` pass will only convert operations from the
+the `-finalize-memref-to-llvm` pass will only convert operations from the
`memref` dialect but will not convert operations from other dialects even if
they use or produce `memref`-typed values.