summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid Teigland <teigland@redhat.com>2016-04-07 13:45:26 -0500
committerDavid Teigland <teigland@redhat.com>2016-04-11 13:17:34 -0500
commit636a0ee18f899c7ef04da0c647e9b47ed990704e (patch)
treee5afdaafb54b549d2d3bc8cfd8c6cf70f4a7ceb6
parent9b55b5082bcd5f681fa69235d9b18ba0b9c99874 (diff)
downloadlvm2-dev-dct-lvmetad-disabled-dups-10.tar.gz
toollib: remove unneeded call in process_each_pvdev-dct-lvmetad-disabled-dups-10
process_each_pv was doing: 1. lvmcache_seed_infos_from_lvmetad() sends pv_list request to lvmetad. 2. get_vgnameids() sends vg_list request to lvmetad. 3. _get_all_devices() first calls lvmcache_seed_infos_from_lvmetad(), which is a no-op if it's already been called. Because get_vgnameids() does not use the information from lvmcache_seed_infos_from_lvmetad(), it does not need to be called prior to get_all_devices where it is actually needed.
-rw-r--r--tools/toollib.c6
1 files changed, 0 insertions, 6 deletions
diff --git a/tools/toollib.c b/tools/toollib.c
index ea6f4bc39..af6054751 100644
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -3356,12 +3356,6 @@ int process_each_pv(struct cmd_context *cmd,
dev_cache_full_scan(cmd->full_filter);
}
- /*
- * Need pvid's set on all PVs before processing so that pvid's
- * can be compared to find duplicates while processing.
- */
- lvmcache_seed_infos_from_lvmetad(cmd);
-
if (!get_vgnameids(cmd, &all_vgnameids, only_this_vgname, 1)) {
stack;
return ret;