summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2023-04-26 13:38:22 +0200
committerZdenek Kabelac <zkabelac@redhat.com>2023-05-06 19:22:05 +0200
commitfae0ed8f10bc5771423f2b7af63690800de1ce9f (patch)
tree94ddbc7b80506c50edaba72f9d7bb7acaf6d445f
parent871d9f379f79f1969d71b660164efe18515826c2 (diff)
downloadlvm2-fae0ed8f10bc5771423f2b7af63690800de1ce9f.tar.gz
cov: ensure there is either vg or error_vg
Make it explicitely visible to coverity that _process_pvs_in_vg() is not passing NULL vg.
-rw-r--r--tools/toollib.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/tools/toollib.c b/tools/toollib.c
index 43e628abf..c2d93aaf9 100644
--- a/tools/toollib.c
+++ b/tools/toollib.c
@@ -4525,7 +4525,8 @@ static int _process_pvs_in_vgs(struct cmd_context *cmd, uint32_t read_flags,
error_flags = 0;
vg = vg_read(cmd, vg_name, vg_uuid, read_flags, lockd_state, &error_flags, &error_vg);
- if (_ignore_vg(cmd, error_flags, error_vg, vg_name, NULL, read_flags, &skip, &notfound)) {
+ if (_ignore_vg(cmd, error_flags, error_vg, vg_name, NULL, read_flags, &skip, &notfound) ||
+ (!vg && !error_vg)) {
stack;
ret_max = ECMD_FAILED;
report_log_ret_code(ret_max);
@@ -4535,7 +4536,7 @@ static int _process_pvs_in_vgs(struct cmd_context *cmd, uint32_t read_flags,
}
if (notfound)
goto endvg;
-
+
/*
* Don't call "continue" when skip is set, because we need to remove
* error_vg->pvs entries from devices list.