summaryrefslogtreecommitdiff
path: root/daemons
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2023-05-10 13:01:37 +0200
committerZdenek Kabelac <zkabelac@redhat.com>2023-05-10 16:19:46 +0200
commitd418fc14f48ba8feb3f5c561f5626a673aef4863 (patch)
tree692634cf4d70a2ab3e4d0991b61d00065b216e67 /daemons
parentcc7c41abbdb51a1e6c60c4a79aa56fe40ab7937a (diff)
downloadlvm2-d418fc14f48ba8feb3f5c561f5626a673aef4863.tar.gz
cov: hide some false positives
Hide some false positives. Note: there must not a be blank line after coverity hiding comment.
Diffstat (limited to 'daemons')
-rw-r--r--daemons/dmeventd/dmeventd.c2
-rw-r--r--daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c1
2 files changed, 3 insertions, 0 deletions
diff --git a/daemons/dmeventd/dmeventd.c b/daemons/dmeventd/dmeventd.c
index d89ab4af8..490768b63 100644
--- a/daemons/dmeventd/dmeventd.c
+++ b/daemons/dmeventd/dmeventd.c
@@ -987,6 +987,7 @@ static void _monitor_unregister(void *arg)
DEBUGLOG("Unregistering monitor for %s.", thread->device.name);
_unregister_for_timeout(thread);
+ /* coverity[missing_lock] no missing lock here */
if ((thread->status != DM_THREAD_REGISTERING) &&
!_do_unregister_device(thread))
log_error("%s: %s unregister failed.", __func__,
@@ -1969,6 +1970,7 @@ static void _daemonize(void)
(void) close(fd);
}
+ /* coverity[leaked_handle] dont't care */
if ((open("/dev/null", O_RDONLY) < 0) ||
(open("/dev/null", O_WRONLY) < 0) ||
(open("/dev/null", O_WRONLY) < 0))
diff --git a/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c b/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c
index 56498170f..cddf6cee8 100644
--- a/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c
+++ b/daemons/dmeventd/plugins/lvm2/dmeventd_lvm.c
@@ -123,6 +123,7 @@ struct dm_pool *dmeventd_lvm2_pool(void)
int dmeventd_lvm2_run(const char *cmdline)
{
+ /* coverity[missing_lock] no locking for run part */
return (lvm2_run(_lvm_handle, cmdline) == LVM2_COMMAND_SUCCEEDED);
}