diff options
author | Tony Asleson <tasleson@redhat.com> | 2023-03-30 10:07:13 -0500 |
---|---|---|
committer | Tony Asleson <tasleson@redhat.com> | 2023-03-30 11:04:42 -0500 |
commit | f7ca470abe995210e8008084c0b4436292b2816b (patch) | |
tree | f153f5008762661981ebdc204ebc6ea5973523a9 /daemons | |
parent | d6f8f59239c65a7f1f9be1d24bf9ba02cfee5b0e (diff) | |
download | lvm2-f7ca470abe995210e8008084c0b4436292b2816b.tar.gz |
lvmdbusd: Correct locking for _common_log
Reduce the lock time and include the flush in the lock.
Reported by: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Diffstat (limited to 'daemons')
-rw-r--r-- | daemons/lvmdbusd/utils.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/daemons/lvmdbusd/utils.py b/daemons/lvmdbusd/utils.py index 6013b656f..fdd7578c1 100644 --- a/daemons/lvmdbusd/utils.py +++ b/daemons/lvmdbusd/utils.py @@ -323,16 +323,17 @@ def _format_log_entry(msg): def _common_log(msg, *attributes): - cfg.stdout_lock.acquire() msg = _format_log_entry(msg) + cfg.stdout_lock.acquire() + if STDOUT_TTY and attributes: print(color(msg, *attributes)) else: print(msg) - cfg.stdout_lock.release() sys.stdout.flush() + cfg.stdout_lock.release() # Serializes access to stdout to prevent interleaved output |