summaryrefslogtreecommitdiff
path: root/lib/display
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2021-09-21 18:32:21 +0200
committerZdenek Kabelac <zkabelac@redhat.com>2021-09-21 21:03:47 +0200
commit178df1c8f4aa6fa73f9f55f2a7f5f7b8c8c0964d (patch)
tree7d54715fe1e89d8a4dcbb8dbb1a9dd78e37ddc8a /lib/display
parent462ac47003e14975b91832f19bc287bd1a775bb4 (diff)
downloadlvm2-178df1c8f4aa6fa73f9f55f2a7f5f7b8c8c0964d.tar.gz
gcc-fanalyzer: helping understand answer is not null
gcc can't easily see pointer 'answer' is only being checked once 'ret > 0'.
Diffstat (limited to 'lib/display')
-rw-r--r--lib/display/display.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/display/display.c b/lib/display/display.c
index f9c9ef836..3c2c2c2bc 100644
--- a/lib/display/display.c
+++ b/lib/display/display.c
@@ -974,7 +974,7 @@ char yes_no_prompt(const char *prompt, ...)
c = tolower(c);
- if ((ret > 0) && (c == answer[0]))
+ if ((ret > 0) && answer && (c == answer[0]))
answer++; /* Matching, next char */
else if (c == '\n') {
if (feof(stdin))
@@ -1000,7 +1000,7 @@ char yes_no_prompt(const char *prompt, ...)
/* Ignore any whitespace before */
--i;
goto nextchar;
- } else if ((ret > 0) && isspace(c)) {
+ } else if ((ret > 0) && answer && isspace(c)) {
/* Ignore any whitespace after */
while (*answer)
answer++; /* jump to end-of-word */