summaryrefslogtreecommitdiff
path: root/libdm
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2020-09-28 23:12:48 +0200
committerZdenek Kabelac <zkabelac@redhat.com>2020-10-19 16:53:18 +0200
commitb2a326b511950c301fceb7f4901671af53f0e8af (patch)
treeeda418166754c088d575bf3d10de518dbe09487d /libdm
parent4b0565b82f9f2bab0d9fdbc23c63e63cbddba61d (diff)
downloadlvm2-b2a326b511950c301fceb7f4901671af53f0e8af.tar.gz
libdm: validate thin-pool before sending messages
Alhtough lvm2 does validation on its side, ensure DM code is not sending messages to failed thin pool.
Diffstat (limited to 'libdm')
-rw-r--r--libdm/libdm-deptree.c9
1 files changed, 9 insertions, 0 deletions
diff --git a/libdm/libdm-deptree.c b/libdm/libdm-deptree.c
index ffd084e52..59616eb3a 100644
--- a/libdm/libdm-deptree.c
+++ b/libdm/libdm-deptree.c
@@ -1600,6 +1600,15 @@ static int _node_send_messages(struct dm_tree_node *dnode,
if (!have_messages || !send)
return 1; /* transaction_id is matching */
+ if (stp.fail || stp.read_only || stp.needs_check) {
+ log_error("Cannot send messages to thin pool %s%s%s%s.",
+ _node_name(dnode),
+ stp.fail ? " in failed state" : "",
+ stp.read_only ? " with read only metadata" : "",
+ stp.needs_check ? " which needs check first" : "");
+ return 0;
+ }
+
dm_list_iterate_items(tmsg, &seg->thin_messages) {
if (!(_thin_pool_node_message(dnode, tmsg)))
return_0;