diff options
author | Zdenek Kabelac <zkabelac@redhat.com> | 2021-04-22 23:22:01 +0200 |
---|---|---|
committer | Zdenek Kabelac <zkabelac@redhat.com> | 2021-04-23 23:00:55 +0200 |
commit | f678052385dd7fe04e4d4c3681b7dd58b1bca64b (patch) | |
tree | f99ec874ab82fda5bdba564301cefa9b05b64b80 /scripts | |
parent | 6a099707c433f0b3f2644c52f7773751832693a4 (diff) | |
download | lvm2-f678052385dd7fe04e4d4c3681b7dd58b1bca64b.tar.gz |
shellcheck: updates
Ehance some shellcheck reported issues.
Diffstat (limited to 'scripts')
-rwxr-xr-x | scripts/fsadm.sh | 2 | ||||
-rw-r--r-- | scripts/lvmdump.sh.in | 2 | ||||
-rwxr-xr-x | scripts/vgimportclone.sh | 12 |
3 files changed, 8 insertions, 8 deletions
diff --git a/scripts/fsadm.sh b/scripts/fsadm.sh index 3e1f3d405..9ae422f55 100755 --- a/scripts/fsadm.sh +++ b/scripts/fsadm.sh @@ -383,7 +383,7 @@ detect_device_size() { test -n "$DEVSIZE" || error "Cannot read size of device \"$VOLUME\"." SSSIZE=$("$BLOCKDEV" --getss "$VOLUME" || true) test -n "$SSSIZE" || error "Cannot read sector size of device \"$VOLUME\"." - DEVSIZE=$(( $DEVSIZE * $SSSIZE )) + DEVSIZE=$(( DEVSIZE * SSSIZE )) fi } diff --git a/scripts/lvmdump.sh.in b/scripts/lvmdump.sh.in index 8507151d8..0685d85fb 100644 --- a/scripts/lvmdump.sh.in +++ b/scripts/lvmdump.sh.in @@ -163,7 +163,7 @@ if (( clustered )); then { for i in nodes status services; do - cap_i=$(echo "$i"|tr a-z A-Z) + cap_i=$(echo "$i"|tr "[:lower:]" "[:upper:]") echo "$cap_i:" echo "----------------------------------" log "cman_tool $i 2>> \"$log\"" diff --git a/scripts/vgimportclone.sh b/scripts/vgimportclone.sh index d56827f1e..3d795048a 100755 --- a/scripts/vgimportclone.sh +++ b/scripts/vgimportclone.sh @@ -18,11 +18,11 @@ # following external commands are used throughout the script # echo and test are internal in bash at least -RM=rm -BASENAME=basename -MKTEMP=mktemp -READLINK=readlink -GETOPT=getopt +RM="rm" +BASENAME="basename" +MKTEMP="mktemp" +READLINK="readlink" +GETOPT="getopt" # user may override lvm location by setting LVM_BINARY LVM=${LVM_BINARY:-lvm} @@ -145,7 +145,7 @@ do shift ;; -v|--verbose) - let VERBOSE_COUNT=VERBOSE_COUNT+1 + VERBOSE_COUNT=$(( VERBOSE_COUNT + 1 )) if [ -z "$VERBOSE" ] then VERBOSE="-v" |