diff options
| author | David Teigland <teigland@redhat.com> | 2017-02-07 15:12:24 -0600 |
|---|---|---|
| committer | David Teigland <teigland@redhat.com> | 2017-02-13 08:21:58 -0600 |
| commit | 13a6368522894e9d32544d8fb3d6360bbe9018d1 (patch) | |
| tree | b9cc5022429edd30b62dd47ed0b56b598fa93567 /tools/lvcreate.c | |
| parent | a1386dcca024b51019c1f3be6b153249df06dbac (diff) | |
| download | lvm2-13a6368522894e9d32544d8fb3d6360bbe9018d1.tar.gz | |
args: use arg parsing function for region size
Consolidate the validation of the region size arg
in a new arg parsing function.
Diffstat (limited to 'tools/lvcreate.c')
| -rw-r--r-- | tools/lvcreate.c | 14 |
1 files changed, 0 insertions, 14 deletions
diff --git a/tools/lvcreate.c b/tools/lvcreate.c index 051258535..cd31c9969 100644 --- a/tools/lvcreate.c +++ b/tools/lvcreate.c @@ -545,7 +545,6 @@ static int _read_raid_params(struct cmd_context *cmd, static int _read_mirror_and_raid_params(struct cmd_context *cmd, struct lvcreate_params *lp) { - int pagesize = lvm_getpagesize(); unsigned max_images; if (seg_is_raid(lp)) { @@ -616,19 +615,6 @@ static int _read_mirror_and_raid_params(struct cmd_context *cmd, return 0; } - if (!is_power_of_2(lp->region_size)) { - log_error("Region size (%" PRIu32 ") must be a power of 2", - lp->region_size); - return 0; - } - - if (lp->region_size % (pagesize >> SECTOR_SHIFT)) { - log_error("Region size (%" PRIu32 ") must be a multiple of " - "machine memory page size (%d)", - lp->region_size, pagesize >> SECTOR_SHIFT); - return 0; - } - if (seg_is_mirror(lp) && !_read_mirror_params(cmd, lp)) return_0; |