summaryrefslogtreecommitdiff
path: root/tools/pvmove_poll.c
diff options
context:
space:
mode:
authorZdenek Kabelac <zkabelac@redhat.com>2017-11-24 14:00:22 +0100
committerZdenek Kabelac <zkabelac@redhat.com>2017-11-24 16:09:59 +0100
commit16ef133be2a6aaa0d16078326e739d19eaf5f66b (patch)
tree062d7b90bd4346e31aa342e43020a81151ece9f4 /tools/pvmove_poll.c
parent2a6981a6976368f633942a13cf007b141b2ece0a (diff)
downloadlvm2-16ef133be2a6aaa0d16078326e739d19eaf5f66b.tar.gz
pvmove: finish no longer needs explicit resumed
Activation code can see from holders needed LVs for resume.
Diffstat (limited to 'tools/pvmove_poll.c')
-rw-r--r--tools/pvmove_poll.c17
1 files changed, 0 insertions, 17 deletions
diff --git a/tools/pvmove_poll.c b/tools/pvmove_poll.c
index 36c2d0c5f..982bf9636 100644
--- a/tools/pvmove_poll.c
+++ b/tools/pvmove_poll.c
@@ -92,10 +92,6 @@ int pvmove_update_metadata(struct cmd_context *cmd, struct volume_group *vg,
int pvmove_finish(struct cmd_context *cmd, struct volume_group *vg,
struct logical_volume *lv_mirr, struct dm_list *lvs_changed)
{
- struct lv_list *lvl;
- struct logical_volume *holder;
- int r = 1;
-
if (!dm_list_empty(lvs_changed) &&
(!_detach_pvmove_mirror(cmd, lv_mirr) ||
!replace_lv_with_error_segment(lv_mirr))) {
@@ -106,19 +102,6 @@ int pvmove_finish(struct cmd_context *cmd, struct volume_group *vg,
if (!lv_update_and_reload(lv_mirr))
return_0;
- /* Takes locks and resumed volumes (should be still suspended, but preloaded) */
- dm_list_iterate_items(lvl, lvs_changed) {
- holder = (struct logical_volume *) lv_lock_holder(lvl->lv);
- if (!resume_lv(cmd, holder)) {
- log_error("Failed to reactivate logical volume %s.",
- display_lvname(holder));
- r = 0; /* But try to resume as much as we can */
- }
- }
-
- if (!r)
- return 0;
-
/* Deactivate mirror LV */
if (!deactivate_lv(cmd, lv_mirr)) {
log_error("ABORTING: Unable to deactivate temporary logical "