summaryrefslogtreecommitdiff
path: root/tools/vgcreate.c
diff options
context:
space:
mode:
authorDavid Teigland <teigland@redhat.com>2018-04-09 13:40:49 -0500
committerDavid Teigland <teigland@redhat.com>2018-04-20 11:22:48 -0500
commit9b6a62f9445b104f8b4f14b1ebe8258b360950e4 (patch)
treecb2ad86f5d1e3720449553fb2d7530e320e8413f /tools/vgcreate.c
parentc0973e70a58e7e14e9cca29a0f8ad12719ea554f (diff)
downloadlvm2-9b6a62f9445b104f8b4f14b1ebe8258b360950e4.tar.gz
lvmcache: simplify
Recent changes allow some major simplification of the way lvmcache works and is used. lvmcache_label_scan is now called in a controlled fashion at the start of commands, and not via various unpredictable side effects. Remove various calls to it from other places. lvmcache_label_scan should not be called from anywhere during a command, because it produces an incorrect representation of PVs with no MDAs, and misclassifies them as orphans. This has been a long standing problem. The invalid flag and rescanning based on that is no longer used and removed. The 'force' variation is no longer needed and removed.
Diffstat (limited to 'tools/vgcreate.c')
-rw-r--r--tools/vgcreate.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/tools/vgcreate.c b/tools/vgcreate.c
index 87a296f56..0c4c42854 100644
--- a/tools/vgcreate.c
+++ b/tools/vgcreate.c
@@ -82,7 +82,6 @@ int vgcreate(struct cmd_context *cmd, int argc, char **argv)
return ECMD_FAILED;
}
- lvmcache_force_next_label_scan();
lvmcache_label_scan(cmd); /* Does nothing when using lvmetad. */
lvmcache_seed_infos_from_lvmetad(cmd); /* Does nothing unless using lvmetad. */