summaryrefslogtreecommitdiff
path: root/tools/vgimportdevices.c
diff options
context:
space:
mode:
authorDavid Teigland <teigland@redhat.com>2022-04-06 12:20:26 -0500
committerDavid Teigland <teigland@redhat.com>2022-04-06 12:20:26 -0500
commit151ce8b27672134438d0bc457f49123db96a176c (patch)
tree75e03db20a020589a9635b805bb72cd1abe11908 /tools/vgimportdevices.c
parentf840dbb3205754db1a339aba8e0f68fa40138ba1 (diff)
downloadlvm2-151ce8b27672134438d0bc457f49123db96a176c.tar.gz
vgimportdevices: fix incorrect deviceidtype usage
When a VG has PVs with different device id types, it would try to use the idtype of the previous PV in the loop. This would produce an unncessary warning, or could lead to using the devname idtype when a better idtype is available.
Diffstat (limited to 'tools/vgimportdevices.c')
-rw-r--r--tools/vgimportdevices.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/tools/vgimportdevices.c b/tools/vgimportdevices.c
index 2580613c4..ea205d941 100644
--- a/tools/vgimportdevices.c
+++ b/tools/vgimportdevices.c
@@ -57,8 +57,7 @@ static int _vgimportdevices_single(struct cmd_context *cmd,
dm_list_iterate_items(pvl, &vg->pvs) {
pv = pvl->pv;
- if (!idtypestr && pv->device_id_type)
- idtypestr = pv->device_id_type;
+ idtypestr = pv->device_id_type;
memcpy(pvid, &pvl->pv->id.uuid, ID_LEN);
device_id_add(cmd, pv->dev, pvid, idtypestr, NULL);