[SV 40657] Don't create pattern rules for suffix rules with deps.

* NEWS: Update with a backward-compatibility warning.
* src/rule.c (convert_to_pattern): If a suffix rule has dependencies,
do not create a pattern rule for it.  According to the manual suffix
rules with prerequisites are treated as normal targets.
* tests/scrips/features/suffixrules: Create some regression tests for
.SUFFIXES and suffix rules.

1 files changed, 4 insertions, 1 deletions

diff --git a/src/rule.c b/src/rule.c
index 4bd3ff09..0c0204e9 100644
--- a/src/rule.c
+++ b/src/rule.c
@@ -252,7 +252,10 @@ convert_to_pattern (void)
 
           memcpy (rulename + slen, dep_name (d2), s2len + 1);
           f = lookup_file (rulename);
-          if (f == 0 || f->cmds == 0)
+
+          /* No target, or no commands, or it has deps: it can't be a
+             suffix rule.  */
+          if (f == 0 || f->cmds == 0 || f->deps != 0)
             continue;
 
           if (s2len == 2 && rulename[slen] == '.' && rulename[slen + 1] == 'a')