diff options
author | Paul Smith <psmith@gnu.org> | 2022-12-31 10:31:24 -0500 |
---|---|---|
committer | Paul Smith <psmith@gnu.org> | 2022-12-31 10:51:24 -0500 |
commit | 29f453739f0059f632ce2963ca0c68f8bf6c5991 (patch) | |
tree | 64e3f8c59c850aa336820f6f12c534ae979dfdfb /tests/thelp.pl | |
parent | 937e9aa32d8db6537edbd7260315106f7086b340 (diff) | |
download | make-git-29f453739f0059f632ce2963ca0c68f8bf6c5991.tar.gz |
Avoid using false(1) in regression tests
The POSIX standard only requires false(1) to return a "non-zero" exit
code; almost all systems return 1 but some (Solaris!!!) return 255 or
possibly even other values. Use our helper "fail" instead.
* tests/thelp.pl: Have the "fail" command obey -q.
* tests/scripts/features/parallelism: Helper -q no longer prints fail.
* tests/scripts/targets/POSIX: Replace false with #HELPER# -q fail 1.
* tests/scripts/variables/MAKEFLAGS: Ditto.
* tests/scripts/variables/SHELL: Ditto.
Diffstat (limited to 'tests/thelp.pl')
-rwxr-xr-x | tests/thelp.pl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/thelp.pl b/tests/thelp.pl index c243bcb8..8d29e5c3 100755 --- a/tests/thelp.pl +++ b/tests/thelp.pl @@ -103,7 +103,7 @@ sub op { } if ($op eq 'fail') { - print "fail $nm\n"; + print "fail $nm\n" unless $quiet; exit($nm); } |