summaryrefslogtreecommitdiff
path: root/tests/scripts/options/warn
blob: 8c66658e681a44300eb4e66a5d8700dae48adc49 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
#                                                                    -*-perl-*-

$description = "Test the --warn option.";

my %warn_test = (
    '--warn' => '', '--warn=warn' => '', '--warn=error --warn=warn' => '',
    '--warn --warn=error' => '=error',
    '--warn=ignore --warn=error --warn=ignore --warn=invalid-var,invalid-ref,undefined-var' => '=ignore,invalid-var,invalid-ref,undefined-var',
    '--warn=invalid-ref:ignore --warn=error --warn=invalid-var:warn,,,,,undefined-var:error,,,,,' => '=error,invalid-var,invalid-ref:ignore,undefined-var:error'
);

# Verify the deprecated --warn-undefined-variables option
run_make_test(q!
$(info MF=$(MAKEFLAGS))
all:; @#HELPER# env MAKEFLAGS
!,
              '--warn-undefined-variables', "MF= --warn=undefined-var\nMAKEFLAGS= --warn=undefined-var");

# Verify parsing of --warn in various forms.

while (my ($f, $r) = each %warn_test) {
    run_make_test(undef, $f, "MF= --warn$r\nMAKEFLAGS= --warn$r");
}

# Verify that values set in MAKEFLAGS take effect

while (my ($f, $r) = each %warn_test) {
    run_make_test(qq!
MAKEFLAGS += $f
\$(info MF=\$(MAKEFLAGS))
all:; \@#HELPER# env MAKEFLAGS
!,
                  '', "MF= --warn$r\nMAKEFLAGS= --warn$r");
}

# Verify that make's special variables don't warn even if they're not set
run_make_test(q!
vars := $(.VARIABLES) $(MAKECMDGOALS) $(MAKE_RESTARTS) $(CURDIR)
vars += $(GNUMAKEFLAGS) $(MAKEFLAGS) $(MFLAGS) $(MAKE_COMMAND) $(MAKE)
vars += $(MAKEFILE_LIST) $(MAKEOVERRIDES) $(-*-command-variables-*-)
vars += $(.RECIPEPREFIX) $(.LOADED) $(.FEATURES)
vars += $(SHELL) $(.SHELLFLAGS) $(MAKE_TERMOUT) $(MAKE_TERMERR)
vars += $(.DEFAULT) $(.DEFAULT_GOAL) $(-*-eval-flags-*-) $(SUFFIXES)
vars += $(VPATH) $(GPATH)
all:;
!,
              '--warn=undefined-var', "#MAKE#: 'all' is up to date.");

# sv 63609.
# Test for buffer overrun in warn_undefined.
run_make_test(q!
all:;
X := $(averyveryveryloooooooooooooooooooooooooooongvariablename)
!,
              '--warn=undefined-var',
              "#MAKEFILE#:3: warning: reference to undefined variable 'averyveryveryloooooooooooooooooooooooooooongvariablename'
#MAKE#: 'all' is up to date.\n"
);

# Check undefined variable warnings

# With no options or with ignore, nothing should happen
run_make_test('
EMPTY =
EREF = $(EMPTY)
UREF = $(UNDEFINED)

SEREF := $(EREF)
SUREF := $(UREF)

all: ; @echo ref $(EREF) $(UREF)',
              '', 'ref');

run_make_test(undef, '--warn=undefined-var:ignore', 'ref');

# Check warnings
run_make_test(undef, '--warn=undefined-var',
              "#MAKEFILE#:7: warning: reference to undefined variable 'UNDEFINED'
#MAKEFILE#:9: warning: reference to undefined variable 'UNDEFINED'
ref");

# Check and errors
run_make_test(undef, '--warn=undefined-var:error',
              "#MAKEFILE#:7: *** reference to undefined variable 'UNDEFINED'.  Stop.", 512);

# Check invalid variable reference warnings

# With no options we still check for invalid references
run_make_test('
IREF = $(bad variable)
SIREF := $(IREF)

define nl


endef

all: ; @echo ref $(also$(nl)bad) $(IREF) $(SIREF)',
              '', "#MAKEFILE#:2: warning: invalid variable reference 'bad variable'
#MAKEFILE#:10: warning: invalid variable reference 'also\nbad'
#MAKEFILE#:2: warning: invalid variable reference 'bad variable'
ref");

run_make_test(undef, '--warn=ignore', 'ref');

run_make_test(undef, '--warn=invalid-ref:ignore', 'ref');

# Check and errors
run_make_test(undef, '--warn=invalid-ref:error',
              "#MAKEFILE#:2: *** invalid variable reference 'bad variable'.  Stop.", 512);

# Check invalid variable name warnings

# With no options we still check for invalid references
run_make_test('
EMPTY =
SPACE = $(EMPTY) $(EMPTY)
BAD$(SPACE)VAR = foo

define nl


endef

NL$(nl)VAR = bar

define BAD$(SPACE)DEF :=
foo
endef

define NL$(nl)DEF :=
foo
endef

all: ; @echo ref',
              '', "#MAKEFILE#:4: warning: invalid variable name 'BAD VAR'
#MAKEFILE#:11: warning: invalid variable name 'NL\nVAR'
#MAKEFILE#:13: warning: invalid variable name 'BAD DEF'
#MAKEFILE#:17: warning: invalid variable name 'NL\nDEF'
ref");

run_make_test(undef, '--warn=ignore', 'ref');

run_make_test(undef, '--warn=invalid-var:ignore', 'ref');

# Check errors
run_make_test(undef, '--warn=invalid-var:error',
              "#MAKEFILE#:4: *** invalid variable name 'BAD VAR'.  Stop.", 512);

# Make sure unknown warnings and actions fail when given on the command line.

run_make_test(undef, '--warn=no-such-warn',
    "#MAKE#: *** unknown warning 'no-such-warn'.  Stop.", 512);

run_make_test(undef, '--warn=invalid-var:no-such-action',
    "#MAKE#: *** unknown warning action 'no-such-action'.  Stop.", 512);

1;