diff options
| author | Sergei Petrunia <sergey@mariadb.com> | 2023-05-16 15:01:59 +0300 |
|---|---|---|
| committer | Sergei Petrunia <sergey@mariadb.com> | 2023-05-16 15:01:59 +0300 |
| commit | ef911553f442cbb1baaac2af44c38b54fd058c41 (patch) | |
| tree | 430f4a8ecca4164d098cd60a719aaf39cda0548a | |
| parent | e22ddd2cbeddce71d09b49768578e8532f30576c (diff) | |
| download | mariadb-git-ef911553f442cbb1baaac2af44c38b54fd058c41.tar.gz | |
Post-merge fix for comments.bb-11.0-release
| -rw-r--r-- | sql/sql_select.cc | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/sql/sql_select.cc b/sql/sql_select.cc index 9193b40702b..ed29c4399e4 100644 --- a/sql/sql_select.cc +++ b/sql/sql_select.cc @@ -9405,9 +9405,11 @@ best_access_path(JOIN *join, s->cached_forced_index= forced_index; } - /* psergey-11.0-todo: the below should be: - if (disable_jbuf || - (!join->allowed_outer_join_with_cache && (s->table->map & join->outer_join))) */ + /* + Note: the condition checked here is very out of date and incorrect. + Below, we use a more accurate check when assigning the value of + best.use_join_buffer. + */ if ((s->table->map & join->outer_join) || disable_jbuf) { /* |