summaryrefslogtreecommitdiff
path: root/myisam
diff options
context:
space:
mode:
authorunknown <ingo/mydev@chilla.local>2006-07-08 19:25:01 +0200
committerunknown <ingo/mydev@chilla.local>2006-07-08 19:25:01 +0200
commit966481b91296580a9053271fecead4902ef98240 (patch)
treedcb2992c80cbdf8a1c8bcc2928f005a63824f6d3 /myisam
parent666fb945a6c8620f479d172a494a527d08ef33c7 (diff)
parent752b826e0d890b2c3b28146089611c1982b459ed (diff)
downloadmariadb-git-966481b91296580a9053271fecead4902ef98240.tar.gz
Merge chilla.local:/home/mydev/mysql-4.1-bug14400
into chilla.local:/home/mydev/mysql-4.1-amerge sql/sql_class.cc: Auto merged
Diffstat (limited to 'myisam')
-rw-r--r--myisam/mi_rkey.c24
1 files changed, 18 insertions, 6 deletions
diff --git a/myisam/mi_rkey.c b/myisam/mi_rkey.c
index de4cefb19b6..98e1a0a9a26 100644
--- a/myisam/mi_rkey.c
+++ b/myisam/mi_rkey.c
@@ -68,6 +68,7 @@ int mi_rkey(MI_INFO *info, byte *buf, int inx, const byte *key, uint key_len,
if (fast_mi_readinfo(info))
goto err;
+
if (share->concurrent_insert)
rw_rdlock(&share->key_root_lock[inx]);
@@ -89,24 +90,35 @@ int mi_rkey(MI_INFO *info, byte *buf, int inx, const byte *key, uint key_len,
case HA_KEY_ALG_BTREE:
default:
if (!_mi_search(info, keyinfo, key_buff, use_key_length,
- myisam_read_vec[search_flag], info->s->state.key_root[inx]))
+ myisam_read_vec[search_flag], info->s->state.key_root[inx]))
{
- while (info->lastpos >= info->state->data_file_length)
+ /*
+ If we are searching for an exact key (including the data pointer)
+ and this was added by an concurrent insert,
+ then the result is "key not found".
+ */
+ if ((search_flag == HA_READ_KEY_EXACT) &&
+ (info->lastpos >= info->state->data_file_length))
+ {
+ my_errno= HA_ERR_KEY_NOT_FOUND;
+ info->lastpos= HA_OFFSET_ERROR;
+ }
+ else while (info->lastpos >= info->state->data_file_length)
{
/*
Skip rows that are inserted by other threads since we got a lock
Note that this can only happen if we are not searching after an
exact key, because the keys are sorted according to position
*/
-
if (_mi_search_next(info, keyinfo, info->lastkey,
- info->lastkey_length,
- myisam_readnext_vec[search_flag],
- info->s->state.key_root[inx]))
+ info->lastkey_length,
+ myisam_readnext_vec[search_flag],
+ info->s->state.key_root[inx]))
break;
}
}
}
+
if (share->concurrent_insert)
rw_unlock(&share->key_root_lock[inx]);