diff options
| author | Andrei Elkin <andrei.elkin@mariadb.com> | 2020-03-08 21:52:30 +0200 |
|---|---|---|
| committer | Andrei Elkin <andrei.elkin@mariadb.com> | 2020-03-15 17:04:29 +0200 |
| commit | dc9057184296583af86522c12c27204401819c75 (patch) | |
| tree | dfa3c5e2ba3b52364d04c0a4c04769f3184eb8cd /sql/handler.h | |
| parent | a467e6755dc28159ee0bef42bea35cffb9b7bacb (diff) | |
| download | mariadb-git-bb-10.5-mdev_742.tar.gz | |
MDEV-742: read-only, pure myisam, binlog-*, @@skip_log_bin corner casesbb-10.5-mdev_742
(Pushed to 10.5)
Are addressed along the following policies.
Prepared read-only, or on non-transactional engines, or
binlog-* filter in binlog, or skipped to binlog XA:s remains in the xid cache after disconnect.
But their consequent completion with Commit or Rollback differs.
1. The read-only at reconnect marks XID to fail for future
completion with ER_XA_RBROLLBACK.
2. `binlog-*` filtered XA when it changes engine data is regarded
as loggable even when nothing got cached for binlog.
An empty XA-prepare group is recorded. Consequent Commit-or-Rollback
succeeds in the Engine(s) as well as recorded into binlog.
3. The same applies to the non-transactional engine XA.
4. @@skip_log_bin=OFF does not record anything at XA-prepare (obviously),
but the completion event is recorded into binlog to admit
inconsistency with slave.
The following actions are taken by the patch.
At XA-prepare:
when empty binlog cache - don't do anything to binlog if RO,
otherwise write empty XA_prepare (assert(binlog-filter case)).
At Disconnect:
when Prepared && RO (=> no binlogging was done)
set Xid_cache_element::error := ER_XA_RBROLLBACK
*keep* XID in the cache, and rollback the transaction.
At XA-"complete":
Discover the error, if any don't binlog the "complete", return the error to the user.
RO patch review notes.
Diffstat (limited to 'sql/handler.h')
| -rw-r--r-- | sql/handler.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sql/handler.h b/sql/handler.h index ebddb659977..22592821164 100644 --- a/sql/handler.h +++ b/sql/handler.h @@ -5173,4 +5173,5 @@ void print_keydup_error(TABLE *table, KEY *key, myf errflag); int del_global_index_stat(THD *thd, TABLE* table, KEY* key_info); int del_global_table_stat(THD *thd, const LEX_CSTRING *db, const LEX_CSTRING *table); +uint ha_count_rw_all(THD *thd, Ha_trx_info **ptr_ha_info); #endif /* HANDLER_INCLUDED */ |