diff options
| author | Vladislav Vaintroub <wlad@mariadb.com> | 2020-01-30 21:11:24 +0100 |
|---|---|---|
| committer | Vladislav Vaintroub <wlad@mariadb.com> | 2020-02-10 12:44:53 +0100 |
| commit | b08579aa28d979e9e45239ff507c22a3399c92a7 (patch) | |
| tree | 474be43c5a186eaeaeb5f3571bd8b57fb1752006 /sql/sql_parse.cc | |
| parent | 6fc72ce169add16272e202b372e6570917365932 (diff) | |
| download | mariadb-git-b08579aa28d979e9e45239ff507c22a3399c92a7.tar.gz | |
MDEV-16308 : protocol messed up sporadically
Context involves semicolon batching, and the error starts 10.2
No reproducible examples were made yet, but TCP trace suggests
multiple packets that are "squeezed" together (e.g overlong OK packet
that has a trailer which is belongs to another packet)
Remove thd->get_stmt_da()->set_skip_flush() when processing a batch.
skip_flush stems from the COM_MULTI code, which was checked in during
10.2 (and is never used)
The fix is confirmed to work, when evaluated by bug reporter (one of them)
We never reproduced it locally, with multiple tries
thus the root cause analysis is still missing.
Diffstat (limited to 'sql/sql_parse.cc')
| -rw-r--r-- | sql/sql_parse.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sql/sql_parse.cc b/sql/sql_parse.cc index 45ce82d7fd8..35b6667a25c 100644 --- a/sql/sql_parse.cc +++ b/sql/sql_parse.cc @@ -1833,7 +1833,6 @@ bool dispatch_command(enum enum_server_command command, THD *thd, while (!thd->killed && (parser_state.m_lip.found_semicolon != NULL) && ! thd->is_error()) { - thd->get_stmt_da()->set_skip_flush(); /* Multiple queries exist, execute them individually */ |