summaryrefslogtreecommitdiff
path: root/sql/sql_partition.cc
diff options
context:
space:
mode:
authorMikael Ronstrom <mikael@mysql.com>2009-10-30 21:44:41 +0100
committerMikael Ronstrom <mikael@mysql.com>2009-10-30 21:44:41 +0100
commit9498a539535eb12c7649a3fd5407fe35165668ed (patch)
tree80a9252eea4875a6877c96f45603b7890a1d7070 /sql/sql_partition.cc
parentc897c59ceb151dfa489ea38e45c7f877ac8cae74 (diff)
downloadmariadb-git-9498a539535eb12c7649a3fd5407fe35165668ed.tar.gz
Fixed such that we fail if using integer constants for character set fields, now need to have correct constant types
Diffstat (limited to 'sql/sql_partition.cc')
-rw-r--r--sql/sql_partition.cc10
1 files changed, 5 insertions, 5 deletions
diff --git a/sql/sql_partition.cc b/sql/sql_partition.cc
index d530a25f05b..81849b57f12 100644
--- a/sql/sql_partition.cc
+++ b/sql/sql_partition.cc
@@ -2240,6 +2240,11 @@ static int add_column_list_values(File fptr, partition_info *part_info,
else
field_cs= NULL;
}
+ if (result_type != item_expr->result_type())
+ {
+ my_error(ER_WRONG_TYPE_COLUMN_VALUE_ERROR, MYF(0));
+ return 1;
+ }
if (field_cs && field_cs != item_expr->collation.collation)
{
if (!(item_expr= convert_charset_partition_constant(item_expr,
@@ -2249,11 +2254,6 @@ static int add_column_list_values(File fptr, partition_info *part_info,
return 1;
}
}
- if (result_type != item_expr->result_type())
- {
- my_error(ER_WRONG_TYPE_COLUMN_VALUE_ERROR, MYF(0));
- return 1;
- }
{
String val_conv;
res= item_expr->val_str(&str);