summaryrefslogtreecommitdiff
path: root/sql/sql_select.h
diff options
context:
space:
mode:
authorOleg Smirnov <olernov@gmail.com>2022-10-01 19:37:25 +0400
committerOleg Smirnov <olernov@gmail.com>2022-10-02 09:23:58 +0400
commitbcaf00f9e52d9b22879f5b4e5c07dc27af7e6bb5 (patch)
treee9c2cded69eb848d33d085f88316e897b5b47882 /sql/sql_select.h
parent2f37c2dfa1a2050e122e026ec0801bba9ba98cfd (diff)
downloadmariadb-git-bb-10.11-MDEV-29624.tar.gz
MDEV-29624 Fix memory leak on pushdown of derived tablebb-10.11-MDEV-29624
Deallocation of TABLE_LIST::dt_handler and TABLE_LIST::pushdown_derived was performed in multiple places if code. This not only made the code more difficult to maintain but also lead to memory leaks when dt_handler and pushdown_derived were allocated but actual pushdown of the derived table did not take place due to the whole embedding unit pushdown. This commit puts deallocation of TABLE_LIST::dt_handler and TABLE_LIST::pushdown_derived to the single point - JOIN::cleanup().
Diffstat (limited to 'sql/sql_select.h')
-rw-r--r--sql/sql_select.h2
1 files changed, 0 insertions, 2 deletions
diff --git a/sql/sql_select.h b/sql/sql_select.h
index 9174d5f7d93..9eb368c6088 100644
--- a/sql/sql_select.h
+++ b/sql/sql_select.h
@@ -2488,8 +2488,6 @@ public:
Pushdown_derived(TABLE_LIST *tbl, derived_handler *h);
- ~Pushdown_derived();
-
int execute();
};