summaryrefslogtreecommitdiff
path: root/sql/table.h
diff options
context:
space:
mode:
authorJorgen Loland <jorgen.loland@oracle.com>2011-06-16 08:24:00 +0200
committerJorgen Loland <jorgen.loland@oracle.com>2011-06-16 08:24:00 +0200
commitebe94178d1bb3fcab49791462634d9e79ea72f25 (patch)
tree32635dc09bff582bae4370798dbd6f8dc204dc61 /sql/table.h
parent0357d0dcedb76f64ea8bbbc81c1f90ec7d886e86 (diff)
downloadmariadb-git-ebe94178d1bb3fcab49791462634d9e79ea72f25.tar.gz
BUG#11882110: UPDATE REPORTS ER_KEY_NOT_FOUND IF TABLE IS
UPDATED TWICE For multi update it is not allowed to update a column of a table if that table is accessed through multiple aliases and either 1) the updated column is used as partitioning key 2) the updated column is part of the primary key and the primary key is clustered This check is done in unsafe_key_update(). The bug was that for case 2), it was checked whether updated_column_number == table_share->primary_key However, the primary_key variable is the index number of the primary key, not a column number. Prior to this bugfix, the first column was wrongly believed to be the primary key. The columns covered by an index is found in table->key_info[idx_number]->key_part. The bugfix is to check if any of the columns in the keyparts of the primary key are updated. The user-visible effect is that for storage engines with clustered primary key (e.g. InnoDB but not MyISAM) queries like "UPDATE t1 AS A JOIN t2 AS B SET A.primkey=..." will now error with "ERROR HY000: Primary key/partition key update is not allowed since the table is updated both as 'A' and 'B'." instead of "ERROR 1032 (HY000): Can't find record in 't1_tb'" even if primkey is not the first column in the table. This was the intended behavior of bugfix 11764529.
Diffstat (limited to 'sql/table.h')
-rw-r--r--sql/table.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/sql/table.h b/sql/table.h
index afdf4f7baa9..81b42c5b013 100644
--- a/sql/table.h
+++ b/sql/table.h
@@ -627,8 +627,8 @@ struct TABLE_SHARE
uint db_options_in_use; /* Options in use */
uint db_record_offset; /* if HA_REC_IN_SEQ */
uint rowid_field_offset; /* Field_nr +1 to rowid field */
- /* Index of auto-updated TIMESTAMP field in field array */
- uint primary_key;
+ /* Primary key index number, used in TABLE::key_info[] */
+ uint primary_key;
uint next_number_index; /* autoincrement key number */
uint next_number_key_offset; /* autoinc keypart offset in a key */
uint next_number_keypart; /* autoinc keypart number in a key */