diff options
| author | Junqi Xie <junqi_xie@outlook.com> | 2023-03-12 13:55:30 +0800 |
|---|---|---|
| committer | Daniel Black <daniel@mariadb.org> | 2023-04-12 11:04:29 +1000 |
| commit | d20a96f9c1c0240eac2ad8520a04f06e218c4e0a (patch) | |
| tree | 2a9bfbd680ebe5079c29dbf11225d249ea1d490b /sql/transaction.cc | |
| parent | 4472a7b4ff79853d931288c1ab8d49bf130e3908 (diff) | |
| download | mariadb-git-d20a96f9c1c0240eac2ad8520a04f06e218c4e0a.tar.gz | |
MDEV-21921 Make transaction_isolation and transaction_read_only into system variables
In MariaDB, we have a confusing problem where:
* The transaction_isolation option can be set in a configuration file, but it cannot be set dynamically.
* The tx_isolation system variable can be set dynamically, but it cannot be set in a configuration file.
Therefore, we have two different names for the same thing in different contexts. This is needlessly confusing, and it complicates the documentation. The same thing applys for transaction_read_only.
MySQL 5.7 solved this problem by making them into system variables. https://dev.mysql.com/doc/relnotes/mysql/5.7/en/news-5-7-20.html
This commit takes a similar approach by adding new system variables and marking the original ones as deprecated. This commit also resolves some legacy problems related to SET STATEMENT and transaction_isolation.
Diffstat (limited to 'sql/transaction.cc')
| -rw-r--r-- | sql/transaction.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sql/transaction.cc b/sql/transaction.cc index 123f9283d23..94c3ec1d1e1 100644 --- a/sql/transaction.cc +++ b/sql/transaction.cc @@ -181,7 +181,7 @@ bool trans_begin(THD *thd, uint flags) } thd->tx_read_only= false; /* - This flags that tx_read_only was set explicitly, rather than + This flags that transaction_read_only was set explicitly, rather than just from the session's default. */ #ifndef EMBEDDED_LIBRARY |