summaryrefslogtreecommitdiff
path: root/storage/connect/libdoc.cpp
diff options
context:
space:
mode:
authorMarko Mäkelä <marko.makela@mariadb.com>2020-02-07 08:12:58 +0200
committerMarko Mäkelä <marko.makela@mariadb.com>2020-02-07 08:12:58 +0200
commit8b97eba31ba3b8af6a93b4836b14d52e1c377900 (patch)
tree653e1ca170bf13a04c1adc45ecf979503ba2a05c /storage/connect/libdoc.cpp
parentcd3bdc09dbcec30926abda69b2277657f5fcb08d (diff)
downloadmariadb-git-8b97eba31ba3b8af6a93b4836b14d52e1c377900.tar.gz
MDEV-21674 purge_sys.stop() fails to wait for purge workers to complete
Since commit 5e62b6a5e06eb02cbde1e34e95e26f42d87fce02 (MDEV-16264), purge_sys_t::stop() no longer waited for all purge activity to stop. This caused problems on FLUSH TABLES...FOR EXPORT because of purge running concurrently with the buffer pool flush. The assertion at the end of buf_flush_dirty_pages() could fail. The, implemented by Vladislav Vaintroub, aims to eliminate race conditions when stopping or resuming purge: waitable_task::disable(): Wait for the task to complete, then replace the task callback function with noop. waitable_task::enable(): Restore the original task callback function after disable(). purge_sys_t::stop(): Invoke purge_coordinator_task.disable(). purge_sys_t::resume(): Invoke purge_coordinator_task.enable(). purge_sys_t::running(): Add const qualifier, and clarify the comment. The purge coordinator task will remain active as long as any purge worker task is active. purge_worker_callback(): Assert purge_sys.running(). srv_purge_wakeup(): Merge with the only caller purge_sys_t::resume(). purge_coordinator_task: Use static linkage.
Diffstat (limited to 'storage/connect/libdoc.cpp')
0 files changed, 0 insertions, 0 deletions