clang15 warnings - unused vars and old prototypes

clang15 finally errors on old prototype definations.

Its also a lot fussier about variables that aren't used
as is the case a number of time with loop counters that
aren't examined.

RocksDB was complaining that its get_range function was
declared without the array length in ha_rocksdb.h. While
a constant is used rather than trying to import the
Rdb_key_def::INDEX_NUMBER_SIZE header (was causing a lot of
errors on the defination of other orders). If the constant
does change can be assured that the same compile warnings will
tell us of the error.

The ha_rocksdb::index_read_map_impl DBUG_EXECUTE_IF was similar
to the existing endless functions used in replication tests.
Its rather moot point as the rocksdb.force_shutdown test that
uses myrocks_busy_loop_on_row_read is currently disabled.

1 files changed, 0 insertions, 2 deletions

diff --git a/storage/tokudb/PerconaFT/ft/txn/txn_manager.cc b/storage/tokudb/PerconaFT/ft/txn/txn_manager.cc
index 1b55844bc7d..8af2f6aab63 100644
--- a/storage/tokudb/PerconaFT/ft/txn/txn_manager.cc
+++ b/storage/tokudb/PerconaFT/ft/txn/txn_manager.cc
@@ -208,12 +208,10 @@ verify_snapshot_system(TXN_MANAGER txn_manager UU()) {
             {
                 //verify neither pair->begin_id nor end_id is in snapshot_xids                
                 TOKUTXN curr_txn = txn_manager->snapshot_head;
-                uint32_t curr_index = 0;
                 while (curr_txn != NULL) {
                     invariant(tuple->begin_id != curr_txn->txnid.parent_id64);
                     invariant(tuple->end_id != curr_txn->txnid.parent_id64);
                     curr_txn = curr_txn->snapshot_next;
-                    curr_index++;
                 }
             }
             {