diff options
-rw-r--r-- | storage/spider/spd_db_conn.cc | 125 | ||||
-rw-r--r-- | storage/spider/spd_db_mysql.cc | 42 |
2 files changed, 4 insertions, 163 deletions
diff --git a/storage/spider/spd_db_conn.cc b/storage/spider/spd_db_conn.cc index 549279fb180..eb9e82858f0 100644 --- a/storage/spider/spd_db_conn.cc +++ b/storage/spider/spd_db_conn.cc @@ -1,5 +1,5 @@ -/* Copyright (C) 2008-2019 Kentoku Shiba - Copyright (C) 2019, 2020, MariaDB Corporation. +/* Copyright (C) 2008, 2019, Kentoku Shiba + Copyright (C) 2019, 2022, MariaDB Corporation. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -1814,12 +1814,6 @@ int spider_db_append_key_where_internal( if (use_key == start_key) { -#ifdef SPIDER_HANDLER_SUPPORT_MULTIPLE_KEY_PARTS - if (spider_dbton[dbton_id].db_util-> - append_column_value(spider, str_part, field, ptr, - share->access_charset)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); -#else if (str_part->length() == SPIDER_SQL_OPEN_PAREN_LEN) { if (str->reserve(SPIDER_SQL_EQUAL_LEN)) @@ -1830,7 +1824,6 @@ int spider_db_append_key_where_internal( share->access_charset)) DBUG_RETURN(HA_ERR_OUT_OF_MEM); } -#endif } } } else { @@ -1870,18 +1863,6 @@ int spider_db_append_key_where_internal( if (use_key == start_key) { -#ifdef SPIDER_HANDLER_SUPPORT_MULTIPLE_KEY_PARTS - if (tgt_key_part_map == 1 || !end_key_part_map) - { - if (str->reserve(SPIDER_SQL_EQUAL_LEN)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); - str->q_append(SPIDER_SQL_EQUAL_STR, SPIDER_SQL_EQUAL_LEN); - } - if (spider_dbton[dbton_id].db_util-> - append_column_value(spider, str_part, field, ptr, - share->access_charset)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); -#else if (str_part->length() == SPIDER_SQL_OPEN_PAREN_LEN) { if (str->reserve(SPIDER_SQL_EQUAL_LEN)) @@ -1892,7 +1873,6 @@ int spider_db_append_key_where_internal( share->access_charset)) DBUG_RETURN(HA_ERR_OUT_OF_MEM); } -#endif } } break; @@ -1942,18 +1922,6 @@ int spider_db_append_key_where_internal( if (use_key == start_key) { -#ifdef SPIDER_HANDLER_SUPPORT_MULTIPLE_KEY_PARTS - if (tgt_key_part_map == 1 || !end_key_part_map) - { - if (str->reserve(SPIDER_SQL_GT_LEN)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); - str->q_append(SPIDER_SQL_GT_STR, SPIDER_SQL_GT_LEN); - } - if (spider_dbton[dbton_id].db_util-> - append_column_value(spider, str_part, field, ptr, - share->access_charset)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); -#else if (str_part->length() == SPIDER_SQL_OPEN_PAREN_LEN) { if (str->reserve(SPIDER_SQL_GT_LEN)) @@ -1964,7 +1932,6 @@ int spider_db_append_key_where_internal( share->access_charset)) DBUG_RETURN(HA_ERR_OUT_OF_MEM); } -#endif } } break; @@ -2015,18 +1982,6 @@ int spider_db_append_key_where_internal( if (use_key == start_key) { -#ifdef SPIDER_HANDLER_SUPPORT_MULTIPLE_KEY_PARTS - if (tgt_key_part_map == 1 || !end_key_part_map) - { - if (str->reserve(SPIDER_SQL_LT_LEN)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); - str->q_append(SPIDER_SQL_LT_STR, SPIDER_SQL_LT_LEN); - } - if (spider_dbton[dbton_id].db_util-> - append_column_value(spider, str_part, field, ptr, - share->access_charset)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); -#else if (str_part->length() == SPIDER_SQL_OPEN_PAREN_LEN) { if (str->reserve(SPIDER_SQL_LT_LEN)) @@ -2037,7 +1992,6 @@ int spider_db_append_key_where_internal( share->access_charset)) DBUG_RETURN(HA_ERR_OUT_OF_MEM); } -#endif } } break; @@ -2088,18 +2042,6 @@ int spider_db_append_key_where_internal( if (use_key == start_key) { -#ifdef SPIDER_HANDLER_SUPPORT_MULTIPLE_KEY_PARTS - if (tgt_key_part_map == 1 || !end_key_part_map) - { - if (str->reserve(SPIDER_SQL_LTEQUAL_LEN)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); - str->q_append(SPIDER_SQL_LTEQUAL_STR, SPIDER_SQL_LTEQUAL_LEN); - } - if (spider_dbton[dbton_id].db_util-> - append_column_value(spider, str_part, field, ptr, - share->access_charset)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); -#else if (str_part->length() == SPIDER_SQL_OPEN_PAREN_LEN) { if (str->reserve(SPIDER_SQL_LTEQUAL_LEN)) @@ -2110,7 +2052,6 @@ int spider_db_append_key_where_internal( share->access_charset)) DBUG_RETURN(HA_ERR_OUT_OF_MEM); } -#endif } } break; @@ -2242,18 +2183,6 @@ int spider_db_append_key_where_internal( if (use_key == start_key) { -#ifdef SPIDER_HANDLER_SUPPORT_MULTIPLE_KEY_PARTS - if (tgt_key_part_map == 1 || !end_key_part_map) - { - if (str->reserve(SPIDER_SQL_GTEQUAL_LEN)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); - str->q_append(SPIDER_SQL_GTEQUAL_STR, SPIDER_SQL_GTEQUAL_LEN); - } - if (spider_dbton[dbton_id].db_util-> - append_column_value(spider, str_part, field, ptr, - share->access_charset)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); -#else if (str_part->length() == SPIDER_SQL_OPEN_PAREN_LEN) { if (str->reserve(SPIDER_SQL_GTEQUAL_LEN)) @@ -2264,7 +2193,6 @@ int spider_db_append_key_where_internal( share->access_charset)) DBUG_RETURN(HA_ERR_OUT_OF_MEM); } -#endif } } break; @@ -2283,14 +2211,6 @@ int spider_db_append_key_where_internal( str_part2->q_append(SPIDER_SQL_AND_STR, SPIDER_SQL_AND_LEN); -#ifdef SPIDER_HANDLER_SUPPORT_MULTIPLE_KEY_PARTS - if (use_key == start_key) - { - if (str_part->reserve(SPIDER_SQL_COMMA_LEN)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); - str_part->q_append(SPIDER_SQL_COMMA_STR, SPIDER_SQL_COMMA_LEN); - } -#endif } } @@ -2342,12 +2262,6 @@ int spider_db_append_key_where_internal( if (use_key == end_key) { -#ifdef SPIDER_HANDLER_SUPPORT_MULTIPLE_KEY_PARTS - if (spider_dbton[dbton_id].db_util-> - append_column_value(spider, str_part, field, ptr, - share->access_charset)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); -#else if (str_part->length() == SPIDER_SQL_OPEN_PAREN_LEN) { if (str->reserve(SPIDER_SQL_EQUAL_LEN)) @@ -2358,7 +2272,6 @@ int spider_db_append_key_where_internal( share->access_charset)) DBUG_RETURN(HA_ERR_OUT_OF_MEM); } -#endif } } } else { @@ -2410,18 +2323,6 @@ int spider_db_append_key_where_internal( if (use_key == end_key) { -#ifdef SPIDER_HANDLER_SUPPORT_MULTIPLE_KEY_PARTS - if (tgt_key_part_map == 1 || !start_key_part_map) - { - if (str->reserve(SPIDER_SQL_LT_LEN)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); - str->q_append(SPIDER_SQL_LT_STR, SPIDER_SQL_LT_LEN); - } - if (spider_dbton[dbton_id].db_util-> - append_column_value(spider, str_part, field, ptr, - share->access_charset)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); -#else if (str_part->length() == SPIDER_SQL_OPEN_PAREN_LEN) { if (str->reserve(SPIDER_SQL_LT_LEN)) @@ -2432,7 +2333,6 @@ int spider_db_append_key_where_internal( share->access_charset)) DBUG_RETURN(HA_ERR_OUT_OF_MEM); } -#endif } } break; @@ -2474,18 +2374,6 @@ int spider_db_append_key_where_internal( if (use_key == end_key) { -#ifdef SPIDER_HANDLER_SUPPORT_MULTIPLE_KEY_PARTS - if (tgt_key_part_map == 1 || !start_key_part_map) - { - if (str->reserve(SPIDER_SQL_LTEQUAL_LEN)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); - str->q_append(SPIDER_SQL_LTEQUAL_STR, SPIDER_SQL_LTEQUAL_LEN); - } - if (spider_dbton[dbton_id].db_util-> - append_column_value(spider, str_part, field, ptr, - share->access_charset)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); -#else if (str_part->length() == SPIDER_SQL_OPEN_PAREN_LEN) { if (str->reserve(SPIDER_SQL_LTEQUAL_LEN)) @@ -2496,7 +2384,6 @@ int spider_db_append_key_where_internal( share->access_charset)) DBUG_RETURN(HA_ERR_OUT_OF_MEM); } -#endif } } break; @@ -2514,14 +2401,6 @@ int spider_db_append_key_where_internal( str_part2->q_append(SPIDER_SQL_AND_STR, SPIDER_SQL_AND_LEN); -#ifdef SPIDER_HANDLER_SUPPORT_MULTIPLE_KEY_PARTS - if (use_key == end_key) - { - if (str_part->reserve(SPIDER_SQL_COMMA_LEN)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); - str_part->q_append(SPIDER_SQL_COMMA_STR, SPIDER_SQL_COMMA_LEN); - } -#endif } } if (use_both && (!start_key_part_map || !end_key_part_map)) diff --git a/storage/spider/spd_db_mysql.cc b/storage/spider/spd_db_mysql.cc index d8fc6d38897..e09cedd7580 100644 --- a/storage/spider/spd_db_mysql.cc +++ b/storage/spider/spd_db_mysql.cc @@ -1,5 +1,5 @@ -/* Copyright (C) 2012-2018 Kentoku Shiba - Copyright (c) 2020, MariaDB Corporation. +/* Copyright (C) 2012, 2018, Kentoku Shiba + Copyright (c) 2020, 2022, MariaDB Corporation. This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -11121,18 +11121,6 @@ int spider_mbase_handler::append_is_null( key->flag == HA_READ_KEY_EXACT || key->flag == HA_READ_KEY_OR_NEXT ) { -#ifdef SPIDER_HANDLER_SUPPORT_MULTIPLE_KEY_PARTS - if (tgt_final) - { - if (str->reserve(SPIDER_SQL_EQUAL_LEN)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); - str->q_append(SPIDER_SQL_EQUAL_STR, SPIDER_SQL_EQUAL_LEN); - } - str = str_part; - if (str->reserve(SPIDER_SQL_NULL_LEN)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); - str->q_append(SPIDER_SQL_NULL_STR, SPIDER_SQL_NULL_LEN); -#else if (str_part->length() == SPIDER_SQL_OPEN_PAREN_LEN) { if (str->reserve(SPIDER_SQL_EQUAL_LEN)) @@ -11143,29 +11131,7 @@ int spider_mbase_handler::append_is_null( DBUG_RETURN(HA_ERR_OUT_OF_MEM); str->q_append(SPIDER_SQL_NULL_STR, SPIDER_SQL_NULL_LEN); } -#endif } else { -#ifdef SPIDER_HANDLER_SUPPORT_MULTIPLE_KEY_PARTS - if (str_part->length() == SPIDER_SQL_OPEN_PAREN_LEN) - { - str = str_part; - str->length(str->length() - SPIDER_SQL_OPEN_PAREN_LEN); - ha_next_pos = str->length(); - if (str->reserve(SPIDER_SQL_FIRST_LEN)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); - str->q_append(SPIDER_SQL_FIRST_STR, SPIDER_SQL_FIRST_LEN); - spider->result_list.ha_read_kind = 1; - } else if (tgt_final) - { - if (str->reserve(SPIDER_SQL_GT_LEN)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); - str->q_append(SPIDER_SQL_GT_STR, SPIDER_SQL_GT_LEN); - str = str_part; - if (str->reserve(SPIDER_SQL_NULL_LEN)) - DBUG_RETURN(HA_ERR_OUT_OF_MEM); - str->q_append(SPIDER_SQL_NULL_STR, SPIDER_SQL_NULL_LEN); - } -#else if (str_part->length() == SPIDER_SQL_OPEN_PAREN_LEN) { str = str_part; @@ -11177,7 +11143,6 @@ int spider_mbase_handler::append_is_null( str->q_append(SPIDER_SQL_FIRST_STR, SPIDER_SQL_FIRST_LEN); spider->result_list.ha_read_kind = 1; } -#endif } str = str_part2; } @@ -11259,9 +11224,6 @@ int spider_mbase_handler::append_where_terminator( } else { str_part2->length(str_part2->length() - SPIDER_SQL_AND_LEN); -#ifdef SPIDER_HANDLER_SUPPORT_MULTIPLE_KEY_PARTS - str_part->length(str_part->length() - SPIDER_SQL_COMMA_LEN); -#endif if (!result_list->ha_read_kind) str_part->q_append(SPIDER_SQL_CLOSE_PAREN_STR, SPIDER_SQL_CLOSE_PAREN_LEN); |