summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
Diffstat
-rw-r--r--client/mysqladmin.cc2
-rw-r--r--sql/examples/ha_archive.cc7
-rw-r--r--sql/examples/ha_example.cc4
-rw-r--r--sql/examples/ha_tina.cc37
-rw-r--r--sql/ha_heap.cc1
-rw-r--r--sql/item_subselect.cc3
-rw-r--r--sql/mysqld.cc8
-rw-r--r--sql/opt_range.h2
-rw-r--r--sql/repl_failsafe.cc2
-rw-r--r--sql/slave.cc2
-rw-r--r--sql/sql_acl.cc10
-rw-r--r--sql/sql_insert.cc2
-rw-r--r--sql/sql_parse.cc2
-rw-r--r--sql/sql_repl.cc1
-rw-r--r--sql/sql_select.cc4
15 files changed, 29 insertions, 58 deletions
diff --git a/client/mysqladmin.cc b/client/mysqladmin.cc
index 0da7d5b3acf..5a4690ea30e 100644
--- a/client/mysqladmin.cc
+++ b/client/mysqladmin.cc
@@ -271,7 +271,7 @@ get_one_option(int optid, const struct my_option *opt __attribute__((unused)),
option_wait=1;
}
else
- option_wait= ~0;
+ option_wait= ~(uint)0;
break;
case '?':
case 'I': /* Info */
diff --git a/sql/examples/ha_archive.cc b/sql/examples/ha_archive.cc
index bc4af0c7dc7..918d85d705d 100644
--- a/sql/examples/ha_archive.cc
+++ b/sql/examples/ha_archive.cc
@@ -575,7 +575,7 @@ int ha_archive::write_row(byte * buf)
written= gzwrite(share->archive_write, buf, table->reclength);
DBUG_PRINT("ha_archive::get_row", ("Wrote %d bytes expected %d", written, table->reclength));
share->dirty= TRUE;
- if (written != table->reclength)
+ if (written != (z_off_t)table->reclength)
goto error;
/*
We should probably mark the table as damagaged if the record is written
@@ -590,7 +590,7 @@ int ha_archive::write_row(byte * buf)
{
(*field)->get_ptr(&ptr);
written= gzwrite(share->archive_write, ptr, (unsigned)size);
- if (written != size)
+ if (written != (z_off_t)size)
goto error;
}
}
@@ -613,7 +613,6 @@ error:
int ha_archive::rnd_init(bool scan)
{
DBUG_ENTER("ha_archive::rnd_init");
- int read; // gzread() returns int, and we use this to check the header
/* We rewind the file so that we can read from the beginning if scan */
if (scan)
@@ -747,7 +746,7 @@ int ha_archive::rnd_pos(byte * buf, byte *pos)
DBUG_ENTER("ha_archive::rnd_pos");
statistic_increment(ha_read_rnd_count,&LOCK_status);
current_position= ha_get_ptr(pos, ref_length);
- z_off_t seek= gzseek(archive, current_position, SEEK_SET);
+ (void)gzseek(archive, current_position, SEEK_SET);
DBUG_RETURN(get_row(archive, buf));
}
diff --git a/sql/examples/ha_example.cc b/sql/examples/ha_example.cc
index cb0780ea74d..35034fc7b28 100644
--- a/sql/examples/ha_example.cc
+++ b/sql/examples/ha_example.cc
@@ -150,10 +150,8 @@ static EXAMPLE_SHARE *get_share(const char *table_name, TABLE *table)
return share;
-error2:
- thr_lock_delete(&share->lock);
- pthread_mutex_destroy(&share->mutex);
error:
+ pthread_mutex_destroy(&share->mutex);
pthread_mutex_unlock(&example_mutex);
my_free((gptr) share, MYF(0));
diff --git a/sql/examples/ha_tina.cc b/sql/examples/ha_tina.cc
index 0345a170c3c..637ecde8f81 100644
--- a/sql/examples/ha_tina.cc
+++ b/sql/examples/ha_tina.cc
@@ -20,10 +20,10 @@
First off, this is a play thing for me, there are a number of things wrong with it:
*) It was designed for csv and therefor its performance is highly questionable.
*) Indexes have not been implemented. This is because the files can be traded in
- and out of the table directory without having to worry about rebuilding anything.
+ and out of the table directory without having to worry about rebuilding anything.
*) NULLs and "" are treated equally (like a spreadsheet).
*) There was in the beginning no point to anyone seeing this other then me, so there
- is a good chance that I haven't quite documented it well.
+ is a good chance that I haven't quite documented it well.
*) Less design, more "make it work"
Now there are a few cool things with it:
@@ -89,12 +89,12 @@ int get_mmap(TINA_SHARE *share, int write)
{
if (write)
share->mapped_file= (byte *)mmap(NULL, share->file_stat.st_size,
- PROT_READ|PROT_WRITE, MAP_SHARED,
- share->data_file, 0);
+ PROT_READ|PROT_WRITE, MAP_SHARED,
+ share->data_file, 0);
else
share->mapped_file= (byte *)mmap(NULL, share->file_stat.st_size,
- PROT_READ, MAP_PRIVATE,
- share->data_file, 0);
+ PROT_READ, MAP_PRIVATE,
+ share->data_file, 0);
if ((share->mapped_file ==(caddr_t)-1))
{
/*
@@ -144,9 +144,9 @@ static TINA_SHARE *get_share(const char *table_name, TABLE *table)
{
char data_file_name[FN_REFLEN];
if (!my_multi_malloc(MYF(MY_WME | MY_ZEROFILL),
- &share, sizeof(*share),
- &tmp_name, length+1,
- NullS))
+ &share, sizeof(*share),
+ &tmp_name, length+1,
+ NullS))
{
pthread_mutex_unlock(&tina_mutex);
return NULL;
@@ -341,7 +341,6 @@ int ha_tina::find_current_row(byte *buf)
for (Field **field=table->field ; *field ; field++)
{
- int x;
buffer.length(0);
mapped_ptr++; // Increment past the first quote
for(;mapped_ptr != end_ptr; mapped_ptr++)
@@ -736,28 +735,16 @@ int ha_tina::rnd_end()
*/
qsort(chain, (size_t)(chain_ptr - chain), sizeof(tina_set), (qsort_cmp)sort_set);
for (ptr= chain; ptr < chain_ptr; ptr++)
- printf("Chain %d, %d\n", (int)ptr->begin, (int)ptr->end);
- for (ptr= chain; ptr < chain_ptr; ptr++)
{
- //memmove(share->mapped_file + ptr->begin, share->mapped_file
- //+ ptr->end, length - (size_t)ptr->end);
/* We peek a head to see if this is the last chain */
- printf("Delete %d, %d, %d\n", (int)ptr->begin, (int)ptr->end, (int)length);
if (ptr+1 == chain_ptr)
- {
- printf("Shiftina(end) %d(%d) to %d\n", (int)ptr->end, (int)(length - (size_t)ptr->end), (int)ptr->begin);
memmove(share->mapped_file + ptr->begin, share->mapped_file + ptr->end,
length - (size_t)ptr->end);
- }
else
- {
- printf("Shifting %d(%d) to %d\n", (int)ptr->end, (int)((ptr++)->begin - (size_t)ptr->end), (int)ptr->begin);
- memmove(share->mapped_file + ptr->begin, share->mapped_file + ptr->end,
- (size_t)(ptr++)->begin - (size_t)ptr->end);
- }
+ memmove((caddr_t)share->mapped_file + ptr->begin, (caddr_t)share->mapped_file + ptr->end,
+ (size_t)((ptr++)->begin - ptr->end));
length= length - (size_t)(ptr->end - ptr->begin);
}
- printf("Buffer %s\n",share->mapped_file);
/* Truncate the file to the new size */
if (my_chsize(share->data_file, length, 0, MYF(MY_WME)))
@@ -840,7 +827,7 @@ int ha_tina::create(const char *name, TABLE *table_arg, HA_CREATE_INFO *create_i
DBUG_ENTER("ha_tina::create");
if ((create_file= my_create(fn_format(name_buff,name,"",".CSV",MY_REPLACE_EXT|MY_UNPACK_FILENAME),0,
- O_RDWR | O_TRUNC,MYF(MY_WME))) < 0)
+ O_RDWR | O_TRUNC,MYF(MY_WME))) < 0)
DBUG_RETURN(-1);
my_close(create_file,MYF(0));
diff --git a/sql/ha_heap.cc b/sql/ha_heap.cc
index 033fe86720e..d8e4b3d5a9f 100644
--- a/sql/ha_heap.cc
+++ b/sql/ha_heap.cc
@@ -484,7 +484,6 @@ int ha_heap::create(const char *name, TABLE *table_arg,
for (; key_part != key_part_end; key_part++, seg++)
{
- uint flag= key_part->key_type;
Field *field= key_part->field;
if (pos->algorithm == HA_KEY_ALG_BTREE)
seg->type= field->key_type();
diff --git a/sql/item_subselect.cc b/sql/item_subselect.cc
index 301740c50ef..23477481472 100644
--- a/sql/item_subselect.cc
+++ b/sql/item_subselect.cc
@@ -379,9 +379,6 @@ Item_singlerow_subselect::select_transformer(JOIN *join)
return RES_REDUCE;
}
return RES_OK;
-
-err:
- return RES_ERROR;
}
void Item_singlerow_subselect::store(uint i, Item *item)
diff --git a/sql/mysqld.cc b/sql/mysqld.cc
index 8ade81401aa..5e3142ccf0e 100644
--- a/sql/mysqld.cc
+++ b/sql/mysqld.cc
@@ -3355,7 +3355,7 @@ static int bootstrap(FILE *file)
thd->client_capabilities=0;
my_net_init(&thd->net,(st_vio*) 0);
thd->max_client_packet_length= thd->net.max_packet;
- thd->master_access= ~0;
+ thd->master_access= ~(ulong)0;
thd->thread_id=thread_id++;
thread_count++;
@@ -5574,12 +5574,6 @@ static void print_version(void)
server_version,SYSTEM_TYPE,MACHINE_TYPE, MYSQL_COMPILATION_COMMENT);
}
-static void use_help(void)
-{
- print_version();
- printf("Use '--help' or '--no-defaults --help' for a list of available options\n");
-}
-
static void usage(void)
{
if (!(default_charset_info= get_charset_by_csname(default_character_set_name,
diff --git a/sql/opt_range.h b/sql/opt_range.h
index edecdcc6282..b55bb4708bf 100644
--- a/sql/opt_range.h
+++ b/sql/opt_range.h
@@ -143,7 +143,7 @@ class SQL_SELECT :public Sql_alloc {
~SQL_SELECT();
void cleanup();
bool check_quick(THD *thd, bool force_quick_range, ha_rows limit)
- { return test_quick_select(thd, key_map(~0), 0, limit, force_quick_range) < 0; }
+ { return test_quick_select(thd, key_map(~(uint)0), 0, limit, force_quick_range) < 0; }
inline bool skip_record() { return cond ? cond->val_int() == 0 : 0; }
int test_quick_select(THD *thd, key_map keys, table_map prev_tables,
ha_rows limit, bool force_quick_range=0);
diff --git a/sql/repl_failsafe.cc b/sql/repl_failsafe.cc
index 85a51ba9b51..2d8e8a5bf81 100644
--- a/sql/repl_failsafe.cc
+++ b/sql/repl_failsafe.cc
@@ -71,7 +71,7 @@ static int init_failsafe_rpl_thread(THD* thd)
my_net_init(&thd->net, 0);
thd->net.read_timeout = slave_net_timeout;
thd->max_client_packet_length=thd->net.max_packet;
- thd->master_access= ~0;
+ thd->master_access= ~(ulong)0;
thd->priv_user = 0;
pthread_mutex_lock(&LOCK_thread_count);
thd->thread_id = thread_id++;
diff --git a/sql/slave.cc b/sql/slave.cc
index 605f8289946..5a2d3af3845 100644
--- a/sql/slave.cc
+++ b/sql/slave.cc
@@ -2577,7 +2577,7 @@ static int init_slave_thread(THD* thd, SLAVE_THD_TYPE thd_type)
thd->client_capabilities = 0;
my_net_init(&thd->net, 0);
thd->net.read_timeout = slave_net_timeout;
- thd->master_access= ~0;
+ thd->master_access= ~(ulong)0;
thd->priv_user = 0;
thd->slave_thread = 1;
/*
diff --git a/sql/sql_acl.cc b/sql/sql_acl.cc
index 02da05d195f..84259b146ad 100644
--- a/sql/sql_acl.cc
+++ b/sql/sql_acl.cc
@@ -1002,7 +1002,7 @@ static void acl_insert_db(const char *user, const char *host, const char *db,
ulong acl_get(const char *host, const char *ip,
const char *user, const char *db, my_bool db_is_pattern)
{
- ulong host_access= ~0,db_access= 0;
+ ulong host_access= ~(ulong)0,db_access= 0;
uint i,key_length;
char key[ACL_KEY_LENGTH],*tmp_db,*end;
acl_entry *entry;
@@ -3673,7 +3673,7 @@ int mysql_revoke_all(THD *thd, List <LEX_USER> &list)
}
if (replace_user_table(thd, tables[0].table,
- *lex_user, ~0, 1, 0))
+ *lex_user, ~(ulong)0, 1, 0))
{
result= -1;
continue;
@@ -3700,7 +3700,7 @@ int mysql_revoke_all(THD *thd, List <LEX_USER> &list)
if (!strcmp(lex_user->user.str,user) &&
!my_strcasecmp(system_charset_info, lex_user->host.str, host))
{
- if (!replace_db_table(tables[1].table, acl_db->db, *lex_user, ~0, 1))
+ if (!replace_db_table(tables[1].table, acl_db->db, *lex_user, ~(ulong)0, 1))
{
/*
Don't increment counter as replace_db_table deleted the
@@ -3734,7 +3734,7 @@ int mysql_revoke_all(THD *thd, List <LEX_USER> &list)
if (replace_table_table(thd,grant_table,tables[2].table,*lex_user,
grant_table->db,
grant_table->tname,
- ~0, 0, 1))
+ ~(ulong)0, 0, 1))
{
result= -1;
}
@@ -3750,7 +3750,7 @@ int mysql_revoke_all(THD *thd, List <LEX_USER> &list)
columns,
grant_table->db,
grant_table->tname,
- ~0, 1))
+ ~(ulong)0, 1))
{
revoked= 1;
continue;
diff --git a/sql/sql_insert.cc b/sql/sql_insert.cc
index 0258f2c3e07..1d7914c9c76 100644
--- a/sql/sql_insert.cc
+++ b/sql/sql_insert.cc
@@ -1431,7 +1431,7 @@ bool delayed_insert::handle_inserts(void)
if (thd.killed || table->version != refresh_version)
{
thd.killed=1;
- max_rows= ~0; // Do as much as possible
+ max_rows= ~(uint)0; // Do as much as possible
}
/*
diff --git a/sql/sql_parse.cc b/sql/sql_parse.cc
index 80c68dad247..0d67c25cee5 100644
--- a/sql/sql_parse.cc
+++ b/sql/sql_parse.cc
@@ -561,7 +561,6 @@ bool is_update_query(enum enum_sql_command command)
static void time_out_user_resource_limits(THD *thd, USER_CONN *uc)
{
- bool error= 0;
time_t check_time = thd->start_time ? thd->start_time : time(NULL);
DBUG_ENTER("time_out_user_resource_limits");
@@ -587,7 +586,6 @@ static bool check_mqh(THD *thd, uint check_command)
{
#ifndef NO_EMBEDDED_ACCESS_CHECKS
bool error= 0;
- time_t check_time = thd->start_time ? thd->start_time : time(NULL);
USER_CONN *uc=thd->user_connect;
DBUG_ENTER("check_mqh");
DBUG_ASSERT(uc != 0);
diff --git a/sql/sql_repl.cc b/sql/sql_repl.cc
index 24b78bc9a3d..310c2ea03cd 100644
--- a/sql/sql_repl.cc
+++ b/sql/sql_repl.cc
@@ -1341,7 +1341,6 @@ int show_binlogs(THD* thd)
IO_CACHE log;
File file;
const char *errmsg= 0;
- MY_STAT stat_area;
char fname[FN_REFLEN];
List<Item> field_list;
uint length;
diff --git a/sql/sql_select.cc b/sql/sql_select.cc
index fb7f10abb52..d53609ceaa5 100644
--- a/sql/sql_select.cc
+++ b/sql/sql_select.cc
@@ -34,7 +34,7 @@ const char *join_type_str[]={ "UNKNOWN","system","const","eq_ref","ref",
};
const key_map key_map_empty(0);
-const key_map key_map_full(~0);
+const key_map key_map_full(~(uint)0);
static void optimize_keyuse(JOIN *join, DYNAMIC_ARRAY *keyuse_array);
static bool make_join_statistics(JOIN *join,TABLE_LIST *tables,COND *conds,
@@ -3450,7 +3450,7 @@ make_simple_join(JOIN *join,TABLE *tmp_table)
join_tab->select_cond=0;
join_tab->quick=0;
join_tab->type= JT_ALL; /* Map through all records */
- join_tab->keys.init(~0); /* test everything in quick */
+ join_tab->keys.init(~(uint)0); /* test everything in quick */
join_tab->info=0;
join_tab->on_expr=0;
join_tab->ref.key = -1;
View Lorry Controller Status