summaryrefslogtreecommitdiff
path: root/sql/sp.cc
diff options
context:
space:
mode:
Diffstat (limited to 'sql/sp.cc')
-rw-r--r--sql/sp.cc16
1 files changed, 7 insertions, 9 deletions
diff --git a/sql/sp.cc b/sql/sp.cc
index a4c4ca58414..fdfd9a79fef 100644
--- a/sql/sp.cc
+++ b/sql/sp.cc
@@ -1890,8 +1890,6 @@ bool
Sp_handler::sp_show_create_routine(THD *thd,
const Database_qualified_name *name) const
{
- sp_head *sp;
-
DBUG_ENTER("sp_show_create_routine");
DBUG_PRINT("enter", ("type: %s name: %.*s",
type_str(),
@@ -1904,20 +1902,20 @@ Sp_handler::sp_show_create_routine(THD *thd,
It is "safe" to do as long as it doesn't affect the results
of the binary log or the query cache, which currently it does not.
*/
- if (sp_cache_routine(thd, name, false, &sp))
- DBUG_RETURN(TRUE);
-
- if (sp == NULL || sp->show_create_routine(thd, this))
+ sp_head *sp= 0;
+ bool free_sp= db_find_routine(thd, name, &sp) == SP_OK;
+ bool ret= !sp || sp->show_create_routine(thd, this);
+ if (ret)
{
/*
If we have insufficient privileges, pretend the routine
does not exist.
*/
my_error(ER_SP_DOES_NOT_EXIST, MYF(0), type_str(), name->m_name.str);
- DBUG_RETURN(TRUE);
}
-
- DBUG_RETURN(FALSE);
+ if (free_sp)
+ sp_head::destroy(sp);
+ DBUG_RETURN(ret);
}