diff options
| author | Don MacAskill <don@smugmug.com> | 2005-04-05 00:10:26 +0000 |
|---|---|---|
| committer | Don MacAskill <don@smugmug.com> | 2005-04-05 00:10:26 +0000 |
| commit | 1a07ead83cedae5d1e2e99589820797e00792486 (patch) | |
| tree | 3330873c43e94a62341067f898f1f755e0d49c2b /ChangeLog | |
| parent | b585e734f7cd0b11809d039a35fd46d51a9904fb (diff) | |
| download | memcached-1a07ead83cedae5d1e2e99589820797e00792486.tar.gz | |
+2005-04-04
+ * patch from Don MacAskill <don@smugmug.com> 'flush_all' doesn't
+ seem to work properly. Basically, if you try to add a key which
+ is present, but expired, the store fails but the old key is no
+ longer expired.
Subject: Serious bug in memcached - patch attached
Parts/Attachments:
1.1 Shown 44 lines Text
1.2 Shown 22 lines Text
1.3 OK 13 lines Text (charset: UTF-8)
2 3.2 KB Application, "S/MIME Cryptographic Signature"
----------------------------------------
... or, at least, it seems that way. :) 'flush_all' doesn't seem to
work properly. Basically, if you try to add a key which is present, but
expired, the store fails but the old key is no longer expired. Here's
output:
get key1
END
add key1 1 0 2
27
STORED
get key1
VALUE key1 1 2
27
END
flush_all
OK
add key1 1 0 2
28
NOT_STORED
get key1
VALUE key1 1 2
27
END
I suppose it's possible there's some design reason why it behaves that
way, but if so, I don't know what it is. Certainly breaks our stuff. :)
(we built a memcached tracker which controls the state of our pool of
memcached processes. It flushes any hosts/ports which fail at any
writes, among other things, and this bug caused some big problems, as
you can imagine).
Patch against CVS attached. It's probably mildly overkill (probably
doesn't need to destroy the item on a stale 'get', only on 'add', but
it's pretty simple and gives me the warm fuzzies).
Don
git-svn-id: http://code.sixapart.com/svn/memcached/trunk@236 b0b603af-a30f-0410-a34e-baf09ae79d0b
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 6 |
1 files changed, 6 insertions, 0 deletions
@@ -1,3 +1,9 @@ +2005-04-04 + * patch from Don MacAskill <don@smugmug.com> 'flush_all' doesn't + seem to work properly. Basically, if you try to add a key which + is present, but expired, the store fails but the old key is no + longer expired. + 2005-01-14 * Date: Thu, 18 Nov 2004 15:25:59 -0600 From: David Phillips <electrum@gmail.com> |