summaryrefslogtreecommitdiff
path: root/stats_prefix.c
diff options
context:
space:
mode:
authorKhem Raj <raj.khem@gmail.com>2021-06-04 11:33:12 -0700
committerdormando <dormando@rydia.net>2021-07-25 14:45:42 -0700
commit56a0ba62baab4f9acb8606a8754815a4cacf24b7 (patch)
tree71adce4bc55d2f48f5ff9bf5469a56f26de7571b /stats_prefix.c
parentb7aa247c3714d83e4017598d970d172e68af5f15 (diff)
downloadmemcached-56a0ba62baab4f9acb8606a8754815a4cacf24b7.tar.gz
stats_prefix.c: Check for NDEBUG before using total_written variable
When using NDEBUG assert macro is ineffective which is caught by latest clang and reports that total_written is set but unused. Therefore check for NDEBUG to make sure assert is used only when its effective Fixes error: variable 'total_written' set but not used [-Werror,-Wunused-but-set-variable] size_t size = 0, written = 0, total_written = 0; ^ Signed-off-by: Khem Raj <raj.khem@gmail.com>
Diffstat (limited to 'stats_prefix.c')
-rw-r--r--stats_prefix.c8
1 files changed, 6 insertions, 2 deletions
diff --git a/stats_prefix.c b/stats_prefix.c
index 62f0d04..d72e514 100644
--- a/stats_prefix.c
+++ b/stats_prefix.c
@@ -127,8 +127,10 @@ char *stats_prefix_dump(int *length) {
PREFIX_STATS *pfs;
char *buf;
int i, pos;
- size_t size = 0, written = 0, total_written = 0;
-
+ size_t size = 0, written = 0;
+#ifndef NDEBUG
+ size_t total_written = 0;
+#endif
/*
* Figure out how big the buffer needs to be. This is the sum of the
* lengths of the prefixes themselves, plus the size of one copy of
@@ -154,8 +156,10 @@ char *stats_prefix_dump(int *length) {
pfs->prefix, pfs->num_gets, pfs->num_hits,
pfs->num_sets, pfs->num_deletes);
pos += written;
+#ifndef NDEBUG
total_written += written;
assert(total_written < size);
+#endif
}
}