diff options
author | dormando <dormando@rydia.net> | 2019-10-05 13:22:45 -0700 |
---|---|---|
committer | dormando <dormando@rydia.net> | 2020-02-01 14:36:23 -0800 |
commit | b2cadc45dfb514ef16c3353abe18845f146dfb2b (patch) | |
tree | 0f1adf576317d14c45bf87c178deafa426813491 /t/binary-sasl.t | |
parent | 1517d15ecbc3fda6903d6e68be84f0bda7828ec5 (diff) | |
download | memcached-b2cadc45dfb514ef16c3353abe18845f146dfb2b.tar.gz |
network: response stacking for all commands
This change refactors most of memcached's networking frontend code. The
goals with this change:
- Decouple buffer memory from client connections where plausible,
reducing memory usage for currently inactive TCP sessions.
- Allow easy response stacking for all protocols. Previously every
binary command generates a syscall during response. This is no longer
true when multiple commands are read off the wire at once. The new meta
protocol and most text protocol commands are similar.
- Reduce code complexity for network handling. Remove automatic buffer
adjustments, error checking, and so on.
This is accomplished by removing the iovec, msg, and "write buffer"
structures from connection objects. A `mc_resp` object is now used to
represent an individual response. These objects contain small iovec's
and enough detail to be late-combined on transmit. As a side effect,
UDP mode now works with extstore :)
Adding to the iovec always had a remote chance of memory failure, so
every call had to be checked for an error. Now once a response object
is allocated, most manipulations can happen without any checking. This
is both a boost to code robustness and performance for some hot paths.
This patch is the first in a series, focusing on the client response.
Diffstat (limited to 't/binary-sasl.t')
-rwxr-xr-x | t/binary-sasl.t | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/t/binary-sasl.t b/t/binary-sasl.t index 360ab2d..4864694 100755 --- a/t/binary-sasl.t +++ b/t/binary-sasl.t @@ -191,6 +191,7 @@ for my $dir (split(/:/, $ENV{PATH}), last; } } +die "no saslpasswd2 found" unless $saslpasswd_path; my $sasl_realm = 'memcached.realm'; |