summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAlberts Muktupāvels <alberts.muktupavels@gmail.com>2019-11-29 20:54:12 +0200
committerAlberts Muktupāvels <alberts.muktupavels@gmail.com>2019-11-29 20:54:12 +0200
commitfbc79f3d9cc47cc79ea41c4c4f9b8ef12377b1fa (patch)
treec05a60a639ca17c019f3685f3f0589e23530c799
parent186b2b7851208afb52b5239a36a86620d2fcd5c4 (diff)
downloadmetacity-fbc79f3d9cc47cc79ea41c4c4f9b8ef12377b1fa.tar.gz
display: do not focus default window when focus reverts to root
When window that is direct child of root window and have input focus with revert_to set to RevertToParent closes focus will revert to root window. This used to be problem when metacity did not manage override redirect windows. Now fix in commit 714fb3d539cdaf7fafe6205d114e6a29276bd7b7 is obsolete as metacity these days have MetaWindow also for override redirect windows, meaning that focus will be moved to another window when any focused window will close. Also debug message is misleading, it has nothing to do with gnome-session. For example closing any client side decorated GTK window will log this debug message and may move focus to wrong window as we no longer have not_this_one window. Original bug: https://bugzilla.gnome.org/show_bug.cgi?id=153220
-rw-r--r--src/core/display.c13
1 files changed, 0 insertions, 13 deletions
diff --git a/src/core/display.c b/src/core/display.c
index c43ed3d4..adec7758 100644
--- a/src/core/display.c
+++ b/src/core/display.c
@@ -2233,19 +2233,6 @@ event_callback (XEvent *event,
NULL,
meta_display_get_current_time_roundtrip (display));
}
- else if (event->type == FocusIn &&
- event->xfocus.mode == NotifyNormal &&
- event->xfocus.detail == NotifyInferior)
- {
- meta_topic (META_DEBUG_FOCUS,
- "Focus got set to root window, probably due to "
- "gnome-session logout dialog usage (see bug "
- "153220). Setting the default focus window.\n");
- meta_workspace_focus_default_window (screen->active_workspace,
- NULL,
- meta_display_get_current_time_roundtrip (display));
- }
-
}
break;
case KeymapNotify: