diff options
author | Christian Dywan <christian@twotoasts.de> | 2018-08-29 02:32:54 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2018-08-29 02:32:54 +0200 |
commit | e79a2ebe40e5af86fabe62cc403bdaa6db829c85 (patch) | |
tree | 3c704809d890eea014a7931222b15b9943391815 | |
parent | 4061667dea7a9a24c9b8b734d740233c609f13d7 (diff) | |
download | midori-git-e79a2ebe40e5af86fabe62cc403bdaa6db829c85.tar.gz |
Use full pathname for Icon in .desktop for snap (#25)
This change adds a `DESKTOP_ICON` variable in CMake to customize the value of `Icon` in the `.desktop` file, which in the case of the snap should be an absolute filename.
-rw-r--r-- | CMakeLists.txt | 2 | ||||
-rw-r--r-- | data/CMakeLists.txt | 7 | ||||
-rw-r--r-- | snap/snapcraft.yaml | 1 |
3 files changed, 10 insertions, 0 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt index 46076cf5..c5dfbe2e 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -77,6 +77,8 @@ add_custom_target (uninstall install(FILES COPYING README DESTINATION ${CMAKE_INSTALL_DOCDIR}) +set(DESKTOP_ICON "${CMAKE_PROJECT_NAME}" CACHE STRING "The Icon value to be used in the .desktop file") + add_subdirectory (core) add_subdirectory (web) enable_testing() diff --git a/data/CMakeLists.txt b/data/CMakeLists.txt index b83a45b9..76124add 100644 --- a/data/CMakeLists.txt +++ b/data/CMakeLists.txt @@ -18,6 +18,13 @@ list(REMOVE_ITEM DATA_FILES "CMakeLists.txt") foreach(FILE ${DATA_FILES}) if (${FILE} MATCHES ".desktop") if (NOT WIN32) + FILE(READ ${CMAKE_CURRENT_SOURCE_DIR}/${FILE} CONTENT) + # Escape CMake list-separator ";" first + string(REPLACE ";" "\\;" CONTENT "${CONTENT}") + string(REPLACE "Icon=${CMAKE_PROJECT_NAME}" + "Icon=${DESKTOP_ICON}" + CONTENT "${CONTENT}") + FILE(WRITE ${FILE} ${CONTENT}) string(REPLACE ".desktop.in" "" DESKTOP_ID ${FILE}) INTLTOOL_MERGE_DESKTOP (${DESKTOP_ID} po) endif () diff --git a/snap/snapcraft.yaml b/snap/snapcraft.yaml index 6e1316d2..f37a6bfe 100644 --- a/snap/snapcraft.yaml +++ b/snap/snapcraft.yaml @@ -62,6 +62,7 @@ parts: plugin: cmake configflags: - -DCMAKE_INSTALL_DATADIR=/usr/share + - -DDESKTOP_ICON=/usr/share/icons/hicolor/scalable/apps/midori.svg build-packages: - git - valac |