diff options
| author | Matthew Saltz <matthew.saltz@mongodb.com> | 2020-04-15 11:43:47 -0400 |
|---|---|---|
| committer | Evergreen Agent <no-reply@evergreen.mongodb.com> | 2020-04-15 18:50:42 +0000 |
| commit | cdd914a23e7d91e3d8989c9da38ffb558b20ada6 (patch) | |
| tree | 55117587dd549b009b2e3a0e7ae8b22ab143ce9a | |
| parent | 9f01fb4c7560fa4937a0fada1b4517fff6cc33dc (diff) | |
| download | mongo-cdd914a23e7d91e3d8989c9da38ffb558b20ada6.tar.gz | |
SERVER-43519 Remove unneeded TODO
| -rw-r--r-- | jstests/sharding/txn_being_applied_to_secondary_cannot_be_killed.js | 5 | ||||
| -rw-r--r-- | jstests/sharding/txn_two_phase_commit_basic.js | 5 | ||||
| -rw-r--r-- | jstests/sharding/txn_two_phase_commit_failover.js | 5 |
3 files changed, 6 insertions, 9 deletions
diff --git a/jstests/sharding/txn_being_applied_to_secondary_cannot_be_killed.js b/jstests/sharding/txn_being_applied_to_secondary_cannot_be_killed.js index 87583c78714..c4635268dba 100644 --- a/jstests/sharding/txn_being_applied_to_secondary_cannot_be_killed.js +++ b/jstests/sharding/txn_being_applied_to_secondary_cannot_be_killed.js @@ -74,9 +74,8 @@ assert.commandWorked(session.commitTransaction_forTesting()); jsTest.log("Verify that the transaction was committed on all shards."); // Use assert.soon(), because although coordinateCommitTransaction currently blocks // until the commit process is fully complete, it will eventually be changed to only -// block until the decision is *written*, at which point the test can pass the -// operationTime returned by coordinateCommitTransaction as 'afterClusterTime' in the -// read to ensure the read sees the transaction's writes (TODO SERVER-37165). +// block until the decision is *written*, so the documents may not be visible +// immediately. assert.soon(function() { return 3 === st.s.getDB(dbName).getCollection(collName).find().itcount(); }); diff --git a/jstests/sharding/txn_two_phase_commit_basic.js b/jstests/sharding/txn_two_phase_commit_basic.js index 0df014349ae..96217023565 100644 --- a/jstests/sharding/txn_two_phase_commit_basic.js +++ b/jstests/sharding/txn_two_phase_commit_basic.js @@ -236,9 +236,8 @@ const testCommitProtocol = function(shouldCommit, simulateNetworkFailures) { jsTest.log("Verify that the transaction was committed on all shards."); // Use assert.soon(), because although coordinateCommitTransaction currently blocks // until the commit process is fully complete, it will eventually be changed to only - // block until the decision is *written*, at which point the test can pass the - // operationTime returned by coordinateCommitTransaction as 'afterClusterTime' in the - // read to ensure the read sees the transaction's writes (TODO SERVER-37165). + // block until the decision is *written*, so the documents may not be visible + // immediately. assert.soon(function() { return 3 === st.s.getDB(dbName).getCollection(collName).find().itcount(); }); diff --git a/jstests/sharding/txn_two_phase_commit_failover.js b/jstests/sharding/txn_two_phase_commit_failover.js index 1e86c8a3cf3..e482b1e273b 100644 --- a/jstests/sharding/txn_two_phase_commit_failover.js +++ b/jstests/sharding/txn_two_phase_commit_failover.js @@ -173,9 +173,8 @@ const runTest = function(sameNodeStepsUpAfterFailover) { jsTest.log("Verify that the transaction was committed on all shards."); // Use assert.soon(), because although coordinateCommitTransaction currently blocks // until the commit process is fully complete, it will eventually be changed to only - // block until the decision is *written*, at which point the test can pass the - // operationTime returned by coordinateCommitTransaction as 'afterClusterTime' in - // the read to ensure the read sees the transaction's writes (TODO SERVER-37165). + // block until the decision is *written*, so the documents may not be visible + // immediately. assert.soon(function() { return 3 === st.s.getDB(dbName).getCollection(collName).find().itcount(); }); |