SERVER-36272 Catch error in parsing values after % in URIs

1 files changed, 12 insertions, 0 deletions

diff --git a/src/mongo/client/mongo_uri_test.cpp b/src/mongo/client/mongo_uri_test.cpp
index 4d8088ea015..6e97d94e924 100644
--- a/src/mongo/client/mongo_uri_test.cpp
+++ b/src/mongo/client/mongo_uri_test.cpp
@@ -39,6 +39,8 @@
 #include "mongo/unittest/unittest.h"
 
 #include <boost/filesystem/operations.hpp>
+#include <boost/optional.hpp>
+#include <boost/optional/optional_io.hpp>
 
 namespace mongo {
 namespace {
@@ -55,6 +57,7 @@ struct URITestCase {
 
 struct InvalidURITestCase {
     std::string URI;
+    boost::optional<Status> status = boost::none;
 };
 
 const ConnectionString::ConnectionType kMaster = ConnectionString::MASTER;
@@ -354,6 +357,12 @@ const InvalidURITestCase invalidCases[] = {
     // Host list must actually be comma separated.
     {"mongodb://localhost:27017localhost:27018"},
 
+    // % symbol in password must be escaped.
+    {"mongodb://localhost:pass%word@127.0.0.1:27017",
+     Status(ErrorCodes::FailedToParse,
+            "The characters after the % do not form a hex value. Please escape the % or pass a "
+            "valid hex value. ")},
+
     // Domain sockets have to end in ".sock".
     {"mongodb://%2Fnotareal%2Fdomainsock"},
 
@@ -465,6 +474,9 @@ TEST(MongoURI, InvalidURIs) {
         unittest::log() << "Testing URI: " << testCase.URI << '\n';
         auto cs_status = MongoURI::parse(testCase.URI);
         ASSERT_NOT_OK(cs_status);
+        if (testCase.status) {
+            ASSERT_EQUALS(testCase.status, cs_status.getStatus());
+        }
     }
 }