diff options
| author | Henrik Edin <henrik.edin@mongodb.com> | 2020-09-17 17:09:19 -0400 |
|---|---|---|
| committer | Evergreen Agent <no-reply@evergreen.mongodb.com> | 2020-09-26 02:12:49 +0000 |
| commit | 2b82ab88982566114d1bb7667477b71c883b0799 (patch) | |
| tree | c152b35ff047fdc42f69aa6cd6b04fee1d811fe4 /src/mongo/db/index/index_build_interceptor.h | |
| parent | 08e92a678a1ed288f6a95e7950597e082556ae59 (diff) | |
| download | mongo-2b82ab88982566114d1bb7667477b71c883b0799.tar.gz | |
SERVER-50984 Add CollectionPtr to replace usage of const Collection*
It implements a yieldable interface that is used to re-load the
Collection pointer from the catalog after a yield that released locks.
With lock-free reads and copy-on-write on Collection instances releasing
locks without notifying an AutoGetCollection at a higher level may cause
its pointers to dangle if a MODE_X writer installs a new Collection
instance in the catalog.
CollectionPtr should be passed by const reference so a yield can notify
all the way up.
Diffstat (limited to 'src/mongo/db/index/index_build_interceptor.h')
| -rw-r--r-- | src/mongo/db/index/index_build_interceptor.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/mongo/db/index/index_build_interceptor.h b/src/mongo/db/index/index_build_interceptor.h index 2ea3e61ebfa..2eb571650d9 100644 --- a/src/mongo/db/index/index_build_interceptor.h +++ b/src/mongo/db/index/index_build_interceptor.h @@ -132,7 +132,7 @@ public: * following the last inserted record from a previous call to drainWritesIntoIndex. */ Status drainWritesIntoIndex(OperationContext* opCtx, - const Collection* coll, + const CollectionPtr& coll, const InsertDeleteOptions& options, TrackDuplicates trackDups, DrainYieldPolicy drainYieldPolicy); @@ -150,7 +150,7 @@ public: * successful, keys are written directly to the index. Unsuccessful key generation or writes * will return errors. */ - Status retrySkippedRecords(OperationContext* opCtx, const Collection* collection); + Status retrySkippedRecords(OperationContext* opCtx, const CollectionPtr& collection); /** * Returns 'true' if there are no visible records remaining to be applied from the side writes @@ -179,7 +179,7 @@ private: void _initializeMultiKeyPaths(IndexCatalogEntry* entry); Status _applyWrite(OperationContext* opCtx, - const Collection* coll, + const CollectionPtr& coll, const BSONObj& doc, const InsertDeleteOptions& options, TrackDuplicates trackDups, |