SERVER-49800 remove unnecessary std::move() calls

- std::move() on const ref argument to MatchExpression::parse()
- noop std::move on const lambda capture (CollectionCatalog::setCollectionNamespace() rollback handler)
- redundant noexcept check in embedded

1 files changed, 1 insertions, 2 deletions

diff --git a/src/mongo/db/query/query_solution_test.cpp b/src/mongo/db/query/query_solution_test.cpp
index 5b75631d733..bcb4ea7c725 100644
--- a/src/mongo/db/query/query_solution_test.cpp
+++ b/src/mongo/db/query/query_solution_test.cpp
@@ -774,8 +774,7 @@ auto createMatchExprAndProjection(const BSONObj& query, const BSONObj& projObj)
     auto opCtx = serviceCtx.makeOperationContext();
     const boost::intrusive_ptr<ExpressionContext> expCtx(new ExpressionContext(
         opCtx.get(), std::unique_ptr<CollatorInterface>(nullptr), NamespaceString("test.dummy")));
-    StatusWithMatchExpression queryMatchExpr =
-        MatchExpressionParser::parse(query, std::move(expCtx));
+    StatusWithMatchExpression queryMatchExpr = MatchExpressionParser::parse(query, expCtx);
     ASSERT(queryMatchExpr.isOK());
     projection_ast::Projection res = projection_ast::parse(
         expCtx, projObj, queryMatchExpr.getValue().get(), query, ProjectionPolicies{});