SERVER-34798 Remove ServiceContext subclasses and use new ServiceContext in every unit test.

This patch does several loosely related and surprisingly hard to separate things.

1.) Make the ServiceContext class final

2.) Create a mechanism, called ConstructorActions, for running methods on
ServiceContexts immediately after they're built and immediately before they're
destroyed.

3.) Introduce / improve test fixture base classes for tests, giving them fresh
ServiceContext instances for each test case. There is one fixture for tests that
need a storage engine and another for those that do not.

4.) Make several remaining global variables SC decorations in support of (3)

5.) Replace many MONGO_INITIALIZERS that access getGlobalServiceContext with the
new constructor-actions system, which is needed for (3.)

6.) Fix up tests to use the fixtures from (3) and fix tests that silently used
different service contexts in together in a technically illegal fashion that now
breaks.

7.) Utilize (2) as necessary to simplify initialization of new ServiceContexts,
simplifying the fixtures in (3).

1 files changed, 11 insertions, 5 deletions

diff --git a/src/mongo/db/query/query_test_service_context.cpp b/src/mongo/db/query/query_test_service_context.cpp
index d752db15664..490e3aff679 100644
--- a/src/mongo/db/query/query_test_service_context.cpp
+++ b/src/mongo/db/query/query_test_service_context.cpp
@@ -36,13 +36,15 @@
 
 namespace mongo {
 
-QueryTestServiceContext::QueryTestServiceContext() {
-    CollatorFactoryInterface::set(&_serviceContext, stdx::make_unique<CollatorFactoryMock>());
-    _uniqueClient = _serviceContext.makeClient("QueryTest");
+QueryTestServiceContext::QueryTestServiceContext()
+    : _service(ServiceContext::make()), _client(_service->makeClient("query_test")) {
+    CollatorFactoryInterface::set(getServiceContext(), stdx::make_unique<CollatorFactoryMock>());
 }
 
+QueryTestServiceContext::~QueryTestServiceContext() = default;
+
 ServiceContext::UniqueOperationContext QueryTestServiceContext::makeOperationContext() {
-    return _uniqueClient->makeOperationContext();
+    return getClient()->makeOperationContext();
 }
 
 ServiceContext::UniqueOperationContext QueryTestServiceContext::makeOperationContext(
@@ -53,7 +55,11 @@ ServiceContext::UniqueOperationContext QueryTestServiceContext::makeOperationCon
 }
 
 Client* QueryTestServiceContext::getClient() const {
-    return _uniqueClient.get();
+    return _client.get();
+}
+
+ServiceContext* QueryTestServiceContext::getServiceContext() {
+    return _service.get();
 }
 
 }  // namespace mongo